video-area: Inhibit eager reveal of floating controls

This commit inhibits Celluloid from revealing floating controls upon
launching a video or fullscreen toggle. The floating controls should now
be revealed only upon cursor motion.

The old behaviour was rather annoying, especially when the user opened
or fullscreened a video using the keyboard (pressing Enter in Nautilus,
pressing 'f'); Once the Celluloid window opened or fullscreened in this
manner, not using the mouse (cursor) would not trigger the reveal
timeout, which would keep the floating controls revealed indefinitely,
forcing the user to wiggle the cursor to trigger the timeout to hide the
floating controls.

It was also not often the desired default behaviour to even see the
floating controls upon video launch at all. Rather, one might opine that
a keybinding for revealing the floating controls would be a better UX.
Perhaps something like Shift or Alt.

Author: Byron Torres

src/celluloid-video-area.c

@@ -91,6 +91,9 @@ set_fullscreen_state(CelluloidVideoArea *area, gboolean fullscreen);
 static void
 set_cursor_visible(CelluloidVideoArea *area, gboolean visible);
 
+static void
+hide_floating_controls(CelluloidVideoArea *area);
+
 static void
 reveal_controls(CelluloidVideoArea *area);
 
@@ -177,12 +180,19 @@ set_fullscreen_state(CelluloidVideoArea *area, gboolean fullscreen)
 	celluloid_video_area_set_use_floating_header_bar
 		(area, area->use_floating_controls || fullscreen);
 	celluloid_video_area_set_control_box_floating
-		(area, TRUE);
+		(area, area->use_floating_controls || fullscreen);
+}
 
-	adw_toolbar_view_set_reveal_top_bars
-		(ADW_TOOLBAR_VIEW(area->toolbar_view), TRUE);
-	adw_toolbar_view_set_reveal_bottom_bars
-		(ADW_TOOLBAR_VIEW(area->toolbar_view), TRUE);
+static void
+hide_floating_controls(CelluloidVideoArea *area)
+{
+	if(area->use_floating_controls)
+	{
+		adw_toolbar_view_set_reveal_top_bars
+			(ADW_TOOLBAR_VIEW(area->toolbar_view), FALSE);
+		adw_toolbar_view_set_reveal_bottom_bars
+			(ADW_TOOLBAR_VIEW(area->toolbar_view), FALSE);
+	}
 }
 
 static void
@@ -643,9 +653,11 @@ celluloid_video_area_init(CelluloidVideoArea *area)
 			area->use_floating_controls || area->fullscreened);
 
 	adw_toolbar_view_set_reveal_top_bars
-		(ADW_TOOLBAR_VIEW(area->toolbar_view), TRUE);
+		(	ADW_TOOLBAR_VIEW(area->toolbar_view),
+			!area->use_floating_header_bar);
 	adw_toolbar_view_set_reveal_bottom_bars
-		(ADW_TOOLBAR_VIEW(area->toolbar_view), TRUE);
+		(	ADW_TOOLBAR_VIEW(area->toolbar_view),
+			!area->use_floating_controls);
 
 	//TODO: Reduce spacing for headerbar when in compact mode
 	adw_breakpoint_add_setters
@@ -693,25 +705,6 @@ celluloid_video_area_show_toast_message(	CelluloidVideoArea *area,
 	adw_toast_overlay_add_toast(toast_overlay, toast);
 }
 
-void
-celluloid_video_area_set_reveal_control_box(	CelluloidVideoArea *area,
-						gboolean reveal )
-{
-	adw_toolbar_view_set_reveal_bottom_bars
-		(ADW_TOOLBAR_VIEW(area->toolbar_view), reveal);
-
-	g_source_clear(&area->timeout_tag);
-
-	if(reveal)
-	{
-		area->timeout_tag =
-			g_timeout_add_seconds
-			(	FS_CONTROL_HIDE_DELAY,
-				timeout_handler,
-				area );
-	}
-}
-
 void
 celluloid_video_area_set_control_box_visible(	CelluloidVideoArea *area,
 						gboolean visible )
@@ -726,6 +719,7 @@ celluloid_video_area_set_status(	CelluloidVideoArea *area,
 	switch(status)
 	{
 		case CELLULOID_VIDEO_AREA_STATUS_LOADING:
+		hide_floating_controls(area);
 		adw_status_page_set_title
 			(	ADW_STATUS_PAGE(area->initial_page),
 				_("Loading…") );
@@ -737,6 +731,7 @@ celluloid_video_area_set_status(	CelluloidVideoArea *area,
 		break;
 
 		case CELLULOID_VIDEO_AREA_STATUS_IDLE:
+		reveal_controls(area);
 		adw_status_page_set_title
 			(	ADW_STATUS_PAGE(area->initial_page),
 				_("Welcome") );
@@ -748,6 +743,7 @@ celluloid_video_area_set_status(	CelluloidVideoArea *area,
 		break;
 
 		case CELLULOID_VIDEO_AREA_STATUS_PLAYING:
+		hide_floating_controls(area);
 		gtk_stack_set_visible_child
 			(GTK_STACK(area->stack), area->graphics_offload);
 		break;