Skip to content

Remove creation of .params file in phase 2 combine #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove creation of .params file in phase 2 combine #80

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bc767b
do not write .params in combine
mstraka100 Jul 13, 2021
53705cf
removed comment
mstraka100 Jul 13, 2021
c531c24
changed new challenge filename suffix
mstraka100 Jul 13, 2021
7da1b3c
reversed previous change
mstraka100 Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions phase2-cli/src/combine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use phase2::parameters::{verify_transcript, MPCParameters};
use setup_utils::{print_hash, CheckForCorrectness, SubgroupCheckMode, UseCompression};

use algebra::{CanonicalSerialize, BW6_761};
use algebra::BW6_761;

use std::fs::File;
use std::io::{BufRead, BufReader};
Expand Down Expand Up @@ -83,12 +83,4 @@ pub fn combine(
.write(&mut combined_contents, COMBINED_IS_COMPRESSED)
.expect("should have written combined");
std::fs::write(combined_filename, &combined_contents).expect("should have written combined file");

let mut combined_parameters_contents = vec![];
combined
.params
.serialize_uncompressed(&mut combined_parameters_contents)
.expect("should have serialized combined parameters");
std::fs::write(format!("{}.params", combined_filename), &combined_parameters_contents)
.expect("should have written combined parameters file");
}