Skip to content

Conversation

boyvinall
Copy link

@boyvinall boyvinall commented Apr 4, 2025

ceph config-key is useful to be able to configure services, such as setting prometheus.yml config.

Fixes #338

@boyvinall
Copy link
Author

@guits @asm0deuz would appreciate your thoughts here, thanks

@guits
Copy link
Collaborator

guits commented Apr 22, 2025

hi @boyvinall

sorry for the delay, and thanks for your contribution!

A couple of comments:

  • Nit: This is purely cosmetic, but I would suggest renaming *_configkey_* to *_config_key_*.
  • It looks like this is missing some unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for ceph config-key
2 participants