Clippy

Author: jfldde

src/bitcoin.rs

@@ -268,7 +268,7 @@ impl Restart for BitcoinNode {
 
     async fn start(&mut self, config: Option<Self::Config>) -> Result<()> {
         if let Some(config) = config {
-            self.config = config
+            self.config = config;
         }
         self.spawn_output = Self::spawn(&self.config, &self.docker_env).await?;
 
@@ -361,7 +361,7 @@ async fn wait_for_rpc_ready(client: &Client, timeout: Option<Duration>) -> Resul
             Ok(_) => return Ok(()),
             Err(e) => {
                 trace!("[wait_for_rpc_ready] error {e}");
-                sleep(Duration::from_millis(500)).await
+                sleep(Duration::from_millis(500)).await;
             }
         }
     }

src/citrea_config/rollup.rs

@@ -86,7 +86,7 @@ const fn default_max_subscriptions_per_connection() -> u32 {
 pub struct StorageConfig {
     /// Path that can be utilized by concrete rollup implementation
     pub path: PathBuf,
-    /// File descriptor limit for RocksDB
+    /// File descriptor limit for `RocksDB`
     pub db_max_open_files: Option<i32>,
 }
 

src/citrea_config/sequencer.rs

@@ -29,7 +29,7 @@ impl Default for SequencerConfig {
             deposit_mempool_fetch_limit: 10,
             block_production_interval_ms: 100,
             da_update_interval_ms: 100,
-            mempool_conf: Default::default(),
+            mempool_conf: SequencerMempoolConfig::default(),
         }
     }
 }
@@ -57,11 +57,11 @@ pub struct SequencerMempoolConfig {
 impl Default for SequencerMempoolConfig {
     fn default() -> Self {
         Self {
-            pending_tx_limit: 100000,
+            pending_tx_limit: 100_000,
             pending_tx_size: 200,
-            queue_tx_limit: 100000,
+            queue_tx_limit: 100_000,
             queue_tx_size: 200,
-            base_fee_tx_limit: 100000,
+            base_fee_tx_limit: 100_000,
             base_fee_tx_size: 200,
             max_account_slots: 16,
         }

src/client.rs

@@ -86,7 +86,7 @@ impl Client {
         self.client
             .get_sequencer_commitments_on_slot_by_hash(hash)
             .await
-            .map_err(|e| e.into())
+            .map_err(Into::into)
     }
 
     pub async fn ledger_get_head_soft_confirmation_height(&self) -> Result<u64> {

src/config/rollup.rs

@@ -66,7 +66,7 @@ impl From<BitcoinConfig> for BitcoinServiceConfig {
             node_password: v.rpc_password,
             network: v.network,
             da_private_key: None,
-            tx_backup_dir: "".to_string(),
+            tx_backup_dir: String::new(),
         }
     }
 }

src/utils.rs

@@ -27,7 +27,7 @@ pub fn get_workspace_root() -> PathBuf {
         .to_path_buf()
 }
 
-/// Get citrea path from CITREA_E2E_TEST_BINARY env
+/// Get citrea path from `CITREA_E2E_TEST_BINARY` env
 pub fn get_citrea_path() -> Result<PathBuf> {
     std::env::var("CITREA_E2E_TEST_BINARY")
         .map(PathBuf::from)