Skip to content

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Oct 29, 2024

Before logs for only citrea_e2e were shown, the other were suppressed. Now we can see:

2024-10-29T23:35:37.357640Z ERROR panic: thread 'bitcoin_e2e::sequencer_commitments::test_sequencer_sends_commitments_to_da_layer' panicked at 'assertion `left == right` failed
  left: 1
 right: 3': bin/citrea/tests/bitcoin_e2e/sequencer_commitments.rs:193
   0: <backtrace::capture::Backtrace as core::default::Default>::default
             at /home/kpp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.73/src/capture.rs:422:9
   1: log_panics::Config::install_panic_hook::{{closure}}
             at /home/kpp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-panics-2.1.0/src/lib.rs:115:29
   2: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/alloc/src/boxed.rs:2036:9
      std::panicking::rust_panic_with_hook
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:799:13
   3: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:664:13
   4: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/sys_common/backtrace.rs:171:18
   5: rust_begin_unwind
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:652:5
   6: core::panicking::panic_fmt
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:72:14
   7: core::panicking::assert_failed_inner
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:409:17
   8: core::panicking::assert_failed
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:364:5
   9: <all_tests::bitcoin_e2e::sequencer_commitments::SequencerSendCommitmentsToDaTest as citrea_e2e::test_case::TestCase>::run_test::{{closure}}
             at /home/kpp/chainway/secret-sovereign-sdk/bin/citrea/tests/bitcoin_e2e/sequencer_commitments.rs:193:9
  10: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/future/future.rs:123:9
  11: citrea_e2e::test_case::TestCaseRunner<T>::run_test_case::{{closure}}
             at /home/kpp/chainway/citrea-e2e/src/test_case.rs:72:28
  12: citrea_e2e::test_case::TestCaseRunner<T>::run::{{closure}}::{{closure}}::{{closure}}
             at /home/kpp/chainway/citrea-e2e/src/test_case.rs:86:43
  13: citrea_e2e::test_case::TestCaseRunner<T>::run::{{closure}}::{{closure}}::{{closure}}
             at /home/kpp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.3/src/macros/select.rs:557:49
  14: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
             at /home/kpp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.3/src/future/poll_fn.rs:58:9
  15: citrea_e2e::test_case::TestCaseRunner<T>::run::{{closure}}::{{closure}}
             at /home/kpp/chainway/citrea-e2e/src/test_case.rs:82:13
...

@kpp kpp requested a review from jfldde October 29, 2024 23:43
@jfldde
Copy link
Collaborator

jfldde commented Oct 30, 2024

Closing in favour of #34

@jfldde jfldde closed this Oct 30, 2024
@jfldde
Copy link
Collaborator

jfldde commented Oct 30, 2024

This behaviour can already be turned on by running the tests with RUST_LOG=info.
#34 make sure the panic will always be outputted while keeping the log granularity

@kpp kpp deleted the kpp/panic_backtrace branch October 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants