-
Notifications
You must be signed in to change notification settings - Fork 106
feat: Integrate Reth's Mempool maintenance task. #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nightly
Are you sure you want to change the base?
Conversation
84775e2
to
d502a59
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to review function body implementations, just went through which functions was implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to review test in my second review
fn transaction_sender(&self, _id: TxNumber) -> ProviderResult<Option<Address>> { | ||
unimplemented!("transaction_sender") | ||
} | ||
|
||
fn transactions_by_block( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use transactions_by_block_range
as we have the SealedBlock
at the unique call site
Description
Dashboard changes should look something like this

Performance
The notification time and bundle extraction logic shows numbers around the following:
Meaning that they will appear as 0 in the "Stacked Sequencer Block Production Flow" histogram
Linked Issues