Skip to content

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Aug 28, 2025

Description

Dashboard changes should look something like this
Screenshot_20250903_191446

Performance

The notification time and bundle extraction logic shows numbers around the following:

2025-09-10T11:23:01.984627Z  INFO citrea_sequencer::runner: Bundle state extraction took 0.137ms
2025-09-10T11:23:02.019260Z  INFO citrea_sequencer::runner: Canonical notification preparation took 0.305ms

Meaning that they will appear as 0 in the "Stacked Sequencer Block Production Flow" histogram

Linked Issues

@rakanalh rakanalh requested a review from eyusufatik as a code owner August 28, 2025 20:25
@auto-assign auto-assign bot requested a review from jfldde August 28, 2025 20:26
@rakanalh rakanalh force-pushed the rakanalh/mempool-maintenance branch from 84775e2 to d502a59 Compare August 28, 2025 20:35
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 80.62500% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.3%. Comparing base (e349555) to head (a770ac6).
⚠️ Report is 7 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/evm/src/lib.rs 21.2% 26 Missing ⚠️
crates/sequencer/src/db_provider/mod.rs 38.7% 19 Missing ⚠️
crates/sequencer/src/metrics.rs 0.0% 12 Missing ⚠️
crates/evm/src/evm/conversions.rs 0.0% 3 Missing ⚠️
crates/sequencer/src/lib.rs 93.7% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/citrea-stf/src/hooks_impl.rs 0.0% <ø> (ø)
crates/common/src/config/mod.rs 95.5% <100.0%> (+0.2%) ⬆️
crates/evm/src/evm/mod.rs 74.2% <ø> (ø)
crates/evm/src/evm/primitive_types.rs 85.7% <ø> (ø)
crates/evm/src/hooks.rs 87.5% <100.0%> (+0.5%) ⬆️
crates/sequencer/src/mempool.rs 76.4% <100.0%> (+2.1%) ⬆️
crates/sequencer/src/rpc.rs 63.3% <ø> (+11.8%) ⬆️
crates/sequencer/src/runner.rs 94.0% <100.0%> (+2.2%) ⬆️
...ign-sdk/module-system/sov-modules-api/src/hooks.rs 76.5% <ø> (ø)
...module-system/sov-modules-stf-blueprint/src/lib.rs 98.4% <100.0%> (ø)
... and 6 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review function body implementations, just went through which functions was implemented

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to review test in my second review

@rakanalh rakanalh requested a review from ercecan September 2, 2025 18:34
fn transaction_sender(&self, _id: TxNumber) -> ProviderResult<Option<Address>> {
unimplemented!("transaction_sender")
}

fn transactions_by_block(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use transactions_by_block_range as we have the SealedBlock at the unique call site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper mempool maintenance
4 participants