Implement mempool check for wd utxo #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements mempool checking for withdrawal UTXO transactions to prevent users from attempting safe withdrawals with unconfirmed transactions. The change adds validation to ensure withdrawal transactions are confirmed on-chain before proceeding with the withdrawal process.
Key changes:
- Added transaction on-chain verification before preparing withdrawal parameters
- Introduced new API functions to check transaction confirmation status via mempool.space and Bitcoin RPC fallback
- Updated user messaging to inform about confirmation requirements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/withdraw.rs | Added mempool check in prepare_withdrawal_params and imported new API function |
| src/main.rs | Updated user instructions to mention waiting for transaction confirmation |
| src/errors.rs | Added new error type for transactions not found on-chain |
| src/api_utils.rs | Implemented is_tx_on_chain function with mempool.space and Bitcoin RPC fallback |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ceyhunsen
approved these changes
Sep 12, 2025
| @@ -354,6 +354,12 @@ pub async fn prepare_withdrawal_params( | |||
| BridgeCliError, | |||
| > { | |||
| // Get the prepare tx details | |||
There was a problem hiding this comment.
comment needs to be moved below
aoengin
requested changes
Sep 12, 2025
| } | ||
| } | ||
|
|
||
| async fn is_tx_on_chain_mempool_space( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements mempool check for newly created withdrawal (dust) utxo. If not confirmed, gives error for send-safe-withdrawal.