fix: typecheck

segunadebayo · segunadebayo · commit edf1b5fe0339 · 2025-05-12T19:15:26.000+01:00
diff --git a/.changeset/big-pants-float.md b/.changeset/big-pants-float.md
@@ -0,0 +1,6 @@
+---
+"@zag-js/combobox": patch
+"@zag-js/menu": patch
+---
+
+Fix type issue with the `navigate` prop
diff --git a/packages/machines/combobox/src/combobox.types.ts b/packages/machines/combobox/src/combobox.types.ts
@@ -255,7 +255,6 @@ type PropsWithDefault =
   | "openOnChange"
   | "openOnKeyPress"
   | "composite"
-  | "navigate"
   | "loopFocus"
   | "positioning"
   | "openOnClick"
diff --git a/packages/machines/menu/src/menu.types.ts b/packages/machines/menu/src/menu.types.ts
@@ -123,7 +123,7 @@ export interface MenuProps extends DirectionProperty, CommonProperties, Dismissa
   navigate?: ((details: NavigateDetails) => void) | null | undefined
 }
 
-type PropsWithDefault = "closeOnSelect" | "typeahead" | "composite" | "positioning" | "navigate" | "loopFocus"
+type PropsWithDefault = "closeOnSelect" | "typeahead" | "composite" | "positioning" | "loopFocus"
 
 export interface MenuSchema {
   props: RequiredBy<MenuProps, PropsWithDefault>

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ export interface MenuProps extends DirectionProperty, CommonProperties, Dismissa`
`123`	`123`	`navigate?: ((details: NavigateDetails) => void) \| null \| undefined`
`124`	`124`	`}`
`125`	`125`
`126`		`-type PropsWithDefault = "closeOnSelect" \| "typeahead" \| "composite" \| "positioning" \| "navigate" \| "loopFocus"`
	`126`	`+type PropsWithDefault = "closeOnSelect" \| "typeahead" \| "composite" \| "positioning" \| "loopFocus"`
`127`	`127`
`128`	`128`	`export interface MenuSchema {`
`129`	`129`	`props: RequiredBy<MenuProps, PropsWithDefault>`