Minor: Exercise: Optimize use of new variable in get_student_stats_by_question() - refs #3428

Author: ywarnier

main/inc/lib/exercise.lib.php

@@ -3816,31 +3816,29 @@ public static function get_student_stats_by_question(
         $session_id = (int) $session_id;
         $courseId = api_get_course_int_id($course_code);
 
-        if (empty($session_id)) {
-            $courseCondition = "
+        $sql = "SELECT MAX(marks) as max, MIN(marks) as min, AVG(marks) as average
+    		FROM $track_exercises e
+    		";
+        if (true == $onlyStudent) {
+            $courseCondition = '';
+            if (empty($session_id)) {
+                $courseCondition = "
             INNER JOIN $courseUser c
             ON (
                         e.exe_user_id = c.user_id AND
                         e.c_id = c.c_id AND
                         c.status = ".STUDENT."
                         AND relation_type <> 2
-                )
-            ";
-        } else {
-            $courseCondition = "
+                )";
+            } else {
+                $courseCondition = "
             INNER JOIN $courseUser c
             ON (
                         e.exe_user_id = c.user_id AND
                         e.c_id = c.c_id AND
                         c.status = 0
-                )
-            ";
-        }
-
-        $sql = "SELECT MAX(marks) as max, MIN(marks) as min, AVG(marks) as average
-    		FROM $track_exercises e
-    		";
-        if ($onlyStudent == true) {
+                )";
+            }
             $sql .= $courseCondition;
         }
         $sql .= "