Course: Refactor course creation service #5302
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -207,4 +207,27 @@ public function getSubscribedUsersByStatus(Course $course, int $status) | |||
|
|
|||
| return $queryBuilder; | |||
| } | |||
|
|
|||
| public function courseCodeExists(string $code): bool | |||
| return (int) $qb->getSingleScalarResult() > 0; | ||
| } | ||
|
|
||
| public function findCourseAsArray($id) |
|
Code Climate has analyzed commit 576b2a4 and detected 69 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Mejor moverlo a src/CoreBundle/ServiceHelper/EventLoggerHelper
| public function addEvent( | ||
| string $eventType, | ||
| string $valueType, | ||
| $value, |
There was a problem hiding this comment.
El tipado podría ser mixed $value
| if (empty($params['title'])) { | ||
| throw new \InvalidArgumentException('The course title cannot be empty.'); | ||
| } |
There was a problem hiding this comment.
Esto está validado en la misma entidad como Assert\NotBlank
| } else { | ||
| console.error(tempResponse.message) | ||
| } | ||
| const response = await courseService.createCourse(formData) |
There was a problem hiding this comment.
Este servicio que hace la llamada ajax a createCourse, tiene que ser a través de api-platform
| if ($course) { | ||
| return new JsonResponse([ | ||
| 'success' => true, | ||
| 'message' => $translator->trans('Course created successfully.'), | ||
| 'courseId' => $course->getId(), | ||
| ]); | ||
| } | ||
| } catch (\Exception $e) { | ||
|
|
||
| return new JsonResponse([ |
There was a problem hiding this comment.
Aquí se debería lanzar una exception en lugar de devolver una respuesta con json
| } | ||
| } | ||
|
|
||
| public function sendEmailToAdmin(Course $course): void |
There was a problem hiding this comment.
El correo debería enviarse en un EventListener después de crear el curso
| $entityManager->flush(); | ||
| } | ||
|
|
||
| private function insertCourseSettings(Course $course): void |
There was a problem hiding this comment.
También debería hacerse en un entity o event listener
| return $gradebookCategory; | ||
| } | ||
|
|
||
| private function insertExampleContent(Course $course, GradebookCategory $gradebook): void |
There was a problem hiding this comment.
Este método podría ser un servicio a parte, como el de CreateDefaultPages
| $this->createExampleGradebookContent($course, $gradebook, $exercise->id); | ||
| } | ||
|
|
||
| private function createExampleGradebookContent(Course $course, GradebookCategory $parentCategory, int $refId): void |
There was a problem hiding this comment.
Este método podría ser un servicio a parte, como el de CreateDefaultPages
| @@ -730,43 +731,47 @@ public function searchCourseTemplates( | |||
| } | |||
|
|
|||
| #[Route('/create', name: 'chamilo_core_course_create')] | |||
| public function createCourse(Request $request, TranslatorInterface $translator): JsonResponse | |||
| { | |||
| public function createCourse( | |||
There was a problem hiding this comment.
Debería estar en un StateProcessor de ApiPlatform para tener un solo endpoint de creación de curso
No description provided.