[Tasks] Fix error handling for deleted repositories in GitHub move detection #3248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saksham23467 <142910439+saksham23467@users.noreply.github.com>
…etection - Fix 404 error handling to gracefully handle deleted repositories instead of raising exceptions - Add proper task-level error handling with try-catch blocks - Enhance API call retry logic with better error handling - Add validation for repository URL parsing and API responses - Improve logging throughout the process for better monitoring - Mark deleted repositories as IGNORE in database instead of failing tasks Signed-off-by: saksham23467 <142910439+saksham23467@users.noreply.github.com>
saksham23467
force-pushed
the
fix/repo-move-error
branch
from
40596f8 to
bb6d2a0
Compare
|
@saksham23467 : This looks promising. |
Thanks for reviewing! If everything looks good, could you approve the PR so we can move it forward? |
|
@IsaacMilarky / |
Ulincsys
requested changes
Sep 15, 2025
| return results | ||
|
|
||
| @register_metric() | ||
| def clones(repo_group_id, repo_id=None, begin_date=None, end_date=None): |
There was a problem hiding this comment.
It looks like the Clones metric API you implemented for #3247 got included in this PR.
Feature implementations and bugfixes for existing infrastructure should be made into separate PRs. Please rebase and update the PR to only include the error handling changes.
| try: | ||
| owner, name = get_owner_repo(repo.repo_git) | ||
| url = f"https://api.github.com/repos/{owner}/{name}" | ||
| except Exception as e: |
There was a problem hiding this comment.
Where possible and appropriate, please try to catch a specific exception class instead of a bare Exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
ping_github_for_repo_move()to return gracefully instead of raising exceptionsTesting
https://github.com/anaconda-platform/transformers-feedstockreturn 404 errorsThis PR fixes #3166
Notes for Reviewers
Signed commits