Skip to content

fix: skip empty migrations folders #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: skip empty migrations folders #63

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4f581
fix: skip empty migrations folders
oliverhaas Jun 3, 2025
f903c0b
chore: remove added empty line
oliverhaas Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions syzygy/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ def check_migrations(app_configs, **kwargs):
except ImportError:
# This is not the place to deal with migration issues.
continue
if module.__file__ is None:
# Skip empty migration folders, which can happen
# for example when switching between branches.
continue
directory = os.path.dirname(module.__file__)

migration_names = set()
for name in os.listdir(directory):
if name.endswith(".py"):
Expand Down
7 changes: 7 additions & 0 deletions tests/test_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,10 @@ def test_ambiguous_stage(self):
id="migrations.0001",
),
)

def test_empty_migration_folder(self):
with self.settings(MIGRATION_MODULES={"tests": "tests.test_migrations.empty"}):
checks = run_checks(
app_configs=[apps.get_app_config("tests")], tags={"migrations"}
)
self.assertEqual(len(checks), 0)
1 change: 1 addition & 0 deletions tests/test_migrations/empty/.gitkeep
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I actually did this. This is how one is supposed to force an empty folder in git.