Add WithoutOutput option for input-only mode#1555
Open
robin-samuel wants to merge 2 commits intocharmbracelet:v2-expfrom
Open
Add WithoutOutput option for input-only mode#1555robin-samuel wants to merge 2 commits intocharmbracelet:v2-expfrom
robin-samuel wants to merge 2 commits intocharmbracelet:v2-expfrom
Conversation
Add new WithoutOutput() option that disables visual output while preserving raw mode for proper keyboard input handling. This allows arrow keys and other special keys to work without requiring Enter, while standard output functions like println() and logging libraries work correctly. This solves a common issue where users want Bubbletea's input handling but need to use standard output for logging or debugging without the renderer interfering with cursor positioning. Changes: - Add WithoutOutput() option in options.go - Add disableOutput flag to Program struct - Use term.MakeRawOutput() when disableOutput is enabled - Add counter example demonstrating the usage - Update go.mod with local x/term replace directive for development The implementation uses the new term.MakeRawOutput() function which sets raw mode for input while preserving output processing flags (OPOST/ONLCR), ensuring that newlines are automatically converted to CR+LF as expected by standard output functions.
robin-samuel
requested review from
aymanbagabas and
meowgorithm
as code owners
Contributor
Author
|
Note: This PR depends on charmbracelet/x#687 (the The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new WithoutOutput() option that disables visual output while preserving raw mode for proper keyboard input handling. This allows arrow keys and other special keys to work without requiring Enter, while standard output functions like println() and logging libraries work correctly.
This solves a common issue where users want Bubbletea's input handling but need to use standard output for logging or debugging without the renderer interfering with cursor positioning.
Changes:
The implementation uses the new term.MakeRawOutput() function which sets raw mode for input while preserving output processing flags (OPOST/ONLCR), ensuring that newlines are automatically converted to CR+LF as expected by standard output functions.
CONTRIBUTING.md.