-
Notifications
You must be signed in to change notification settings - Fork 23
fixing build issues on mac #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you rename the commit and the PR to fixing build issues on mac |
contains a workaround to fix the path to the libcharm shared library in the c_object_store library
a80c45b
to
d5010bc
Compare
Pinging @mayantaylor for the new branch. We are hoping you can test this on your Apple Silicon machine |
Co-authored-by: Matthias Diener <mdiener@illinois.edu>
Testing on arm (specifically an AppleM2 running Sonoma) produces the following error:
For context, I am running clang 15.0.0: I can fix this problem with the following edit to setup.py...
... however, I don't know enough about clang to say for certain that this will work for all arm64/aarch64 machines (although I assume it will). I've pushed this change. Everything else runs smoothly. |
had to make a new pr to get rid of the ray commits; my original pr was made before ray was merged.