mac arm build and CI addition

[mayantaylor]

Updating setup.py for correct mac build:

• charm++ build needs the architecture specified as arm8 (undoing incorrect change in fixing build issues on mac #254)
• clang installation for charm4py requires architecture specified as arm64
• charmlib.so must be replaced with the mac version (.dylib)

[matthiasdiener]

This looks fine, but could you add more comprehensive architecture testing to CI (either in this PR or a new one)? Currently, only linux-x86_64 seems to be tested.

[matthiasdiener]

is this x86_64 by any chance?

[matthiasdiener]

Also, if the code for the CI steps is identical, this could probably be a build matrix.

[ritvikrao]

I got both the x86 and m1 mac tests to work, but i had to disable thread fork safety checking for it to do so.

[ritvikrao]

Why did you restructure it as a matrix? I split it up because I needed separate run steps for the mac build

[matthiasdiener]

Why did you restructure it as a matrix? I split it up because I needed separate run steps for the mac build

Most of the steps are identical across the different runs; if there are small differences between the steps, we can resolve them in the build script (via e.g. if [[ ${{ matrix.os }} == 'macos-14' ]]; then ...)

[matthiasdiener]

I think this is ready for review @mayantaylor @ritvikrao . I'm not sure if we should add other Python versions or architectures to CI?

[ritvikrao]

i think the tests here are sufficient, this looks good to me