Skip to content

mac arm build and CI addition #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 18, 2024
Merged

mac arm build and CI addition #259

Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f8b5e7b
resolving arch flag issues for mac
mayantaylor Jun 17, 2024
5e0b5b2
adding mac build to test suite
mayantaylor Jun 17, 2024
b8f8e1e
Merge branch 'maya/mac-ci' into maya/mac-build
mayantaylor Jun 17, 2024
d98b8f7
adding macos-12 to actions
mayantaylor Jun 17, 2024
5586bcc
x86 test name
mayantaylor Jun 17, 2024
c8c9971
cleanup and python venv setup
mayantaylor Jun 17, 2024
99cad8f
venv update
mayantaylor Jun 17, 2024
3001ee8
build matrix
mayantaylor Jun 17, 2024
d963a07
adding venv source to test block
mayantaylor Jun 17, 2024
ef1b2fa
lower numpy version for testing
ritvikrao Jun 17, 2024
e250688
setup-python action
ritvikrao Jun 17, 2024
ae84eb2
pip3 additions
ritvikrao Jun 17, 2024
859a5bc
numpy version for x86 build
ritvikrao Jun 17, 2024
fdf49e4
typo
ritvikrao Jun 17, 2024
ee1a55a
python 3.11 for x86
ritvikrao Jun 17, 2024
682f4ce
numpy version reduction
ritvikrao Jun 17, 2024
49da52b
disable fork safety for test on x86
ritvikrao Jun 17, 2024
cfd1cab
set python_requires
matthiasdiener Jun 17, 2024
10afc1f
update URLs
matthiasdiener Jun 17, 2024
e20a469
restructure as matrix
matthiasdiener Jun 17, 2024
b0f49da
install cython
matthiasdiener Jun 17, 2024
de4db71
disable configs that can not work, install filelock package for ray test
matthiasdiener Jun 17, 2024
a9e994b
macos-13 build fixes
matthiasdiener Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion .github/workflows/charm4py.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- cron: '5 0 * * *' # Runs at 00:05 UTC every day.

jobs:
build:
ubuntu-latest:
runs-on: ubuntu-latest

steps:
Expand All @@ -28,3 +28,44 @@ jobs:
export PYTHONPATH="$PWD"
export CHARM4PY_TEST_NUM_PROCESSES=2
python3 auto_test.py

macos-arm:
runs-on: macos-14

steps:
- uses: actions/checkout@v3
- name: build-charm4py
run: |
git fetch --unshallow # Need full repo for 'git describe' used by setup.py
pip3 install setuptools cython cffi greenlet numpy torch torchvision
git clone https://github.com/UIUC-PPL/charm charm_src/charm
export CHARM_EXTRA_BUILD_OPTS="--enable-error-checking"
export CHARM_BUILD_PROCESSES=2
export CHARM4PY_BUILD_CFFI=1
python3 setup.py build_ext --inplace
- name: test-charm4py
run: |
export PYTHONPATH="$PWD"
export CHARM4PY_TEST_NUM_PROCESSES=2
python3 auto_test.py

macos-arm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this x86_64 by any chance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if the code for the CI steps is identical, this could probably be a build matrix.

runs-on: macos-12

steps:
- uses: actions/checkout@v3
- name: build-charm4py
run: |
git fetch --unshallow # Need full repo for 'git describe' used by setup.py
pip3 install setuptools cython cffi greenlet numpy torch torchvision
git clone https://github.com/UIUC-PPL/charm charm_src/charm
export CHARM_EXTRA_BUILD_OPTS="--enable-error-checking"
export CHARM_BUILD_PROCESSES=2
export CHARM4PY_BUILD_CFFI=1
python3 setup.py build_ext --inplace
- name: test-charm4py
run: |
export PYTHONPATH="$PWD"
export CHARM4PY_TEST_NUM_PROCESSES=2
python3 auto_test.py