-
-
Notifications
You must be signed in to change notification settings - Fork 104
feat: Remove webxdc info messages together with webxdc #7021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This allocates a vector of size #messagesToDelete which should be no problem.
780a3e9
to
35dc5d9
Compare
Did you test whether this actually works on a real device (DC Android/Desktop)? Because @adbenitez commented:
|
No, I have to test it on a real device. But rfc724 mid should be be the same across devices, no? |
6da6bd9
to
969da38
Compare
that should be done, building desktop is comparable easy - and testing multi device should be possible by ex-/importing a backup
no. seems they're generated locally and are different on devices. at least this is what i read from the webxdc.rs code at a first glance, reading for 30 seconds :) not saying the PR is not working, however, only answering the question :) as said, testing makes sense here |
This PR adds the feature that webxdc info messages belonging to a wexbdc are deleted when the webxdc is deleted. This is implemented by checking every deleted message whether it has referencing messages with the
SystemMessage
WebxdcInfoMsg
. These messages are then deleted locally, and a delete request is sent out to chat peers. Deletion could also be implemented on the receiving side of a webxdc delete, but with the current implementation, the code is nice and concise and in one place.close #6999