Merge pull request #32 from chickensoft-games/fix/stop

fix: exit and detach on stop

Author: Joanna May

.vscode/launch.json

@@ -6,7 +6,7 @@
       "type": "coreclr",
       "request": "launch",
       "preLaunchTask": "build",
-      "program": "${workspaceFolder}/Chickensoft.LogicBlocks.Example/bin/Debug/net6.0/Chickensoft.LogicBlocks.Example.dll",
+      "program": "${workspaceFolder}/Chickensoft.LogicBlocks.Example/bin/Debug/net7.0/Chickensoft.LogicBlocks.Example.dll",
       "args": [
         // "${input:args}"
       ],
@@ -17,4 +17,4 @@
       "enableStepFiltering": false,
     },
   ]
-}
+}

Chickensoft.LogicBlocks.Generator/src/LogicBlocksGenerator.cs

@@ -8,11 +8,11 @@ namespace Chickensoft.LogicBlocks.Generator;
 using System.Text;
 using System.Threading;
 using Chickensoft.LogicBlocks.Generator.Common.Models;
+using Chickensoft.LogicBlocks.Generator.Common.Services;
 using Chickensoft.SourceGeneratorUtils;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Text;
-using SuperNodes.Common.Services;
 
 [Generator]
 public class LogicBlocksGenerator :

Chickensoft.LogicBlocks.Generator/src/OutputVisitor.cs

@@ -4,11 +4,11 @@ namespace Chickensoft.LogicBlocks.Generator;
 using System.Collections.Immutable;
 using System.Threading;
 using Chickensoft.LogicBlocks.Generator.Common.Models;
+using Chickensoft.LogicBlocks.Generator.Common.Services;
 using Chickensoft.SourceGeneratorUtils;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using SuperNodes.Common.Services;
 
 public class OutputVisitor : CSharpSyntaxWalker {
   public SemanticModel Model { get; }

Chickensoft.LogicBlocks.Generator/src/ReturnTypeVisitor.cs

@@ -3,13 +3,12 @@ namespace Chickensoft.LogicBlocks.Generator;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Threading;
+using Chickensoft.LogicBlocks.Generator.Common.Services;
 using Chickensoft.SourceGeneratorUtils;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 
-using SuperNodes.Common.Services;
-
 public class ReturnTypeVisitor : CSharpSyntaxWalker {
   public SemanticModel Model { get; }
   public CancellationToken Token { get; }

Chickensoft.LogicBlocks.Generator/src/common/services/CodeService.cs

@@ -1,4 +1,4 @@
-namespace SuperNodes.Common.Services;
+namespace Chickensoft.LogicBlocks.Generator.Common.Services;
 
 using System;
 using System.Collections.Generic;

Chickensoft.LogicBlocks/src/LogicBlock.cs

@@ -124,7 +124,11 @@ public void Start() =>
     Value.Enter(previous: null, onError: AddError);
 
   /// <inheritdoc />
-  public void Stop() => Value.Exit(next: null, onError: AddError);
+  public void Stop() {
+    Value.Exit(next: null, onError: AddError);
+    Value.Detach();
+    SetState(null!);
+  }
 
   internal override Func<object, TState> GetInputHandler<TInputType>()
     => (input) => {

Chickensoft.LogicBlocks/src/LogicBlockAsync.cs

@@ -159,7 +159,11 @@ public Task Start() =>
     Value.Enter(previous: null, onError: AddError);
 
   /// <inheritdoc />
-  public Task Stop() => Value.Exit(next: null, onError: AddError);
+  public async Task Stop() {
+    await Value.Exit(next: null, onError: AddError);
+    Value.Detach();
+    SetState(null!);
+  }
 
   internal override Func<object, Task<TState>> GetInputHandler<TInputType>()
     => (input) => {

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
     "rollForward": "latestMinor",
-    "version": "7.0.306"
+    "version": "7.0.404"
   }
-}
+}