Merge pull request #145 from xodial/xodial/fix-infinite-loop

Fix an infinite loop caused when creating input in OnStart

Author: Joanna May

Chickensoft.LogicBlocks.Tests/test/src/LogicBlockTest.cs

@@ -373,6 +373,27 @@ public void ImplicitStartCallsOnStart() {
     onStartCalled.ShouldBeTrue();
   }
 
+  [Fact]
+  public void OnStartDoesNotCauseInfiniteLoopWithInput() {
+    var onStartCalled = false;
+    var looped = false;
+    var logic = new FakeLogicBlock();
+    logic.OnStartCalled += () => {
+      if (onStartCalled) {
+        looped = true;
+        return;
+      }
+
+      onStartCalled = true;
+      logic.Input(new FakeLogicBlock.Input.InputOne(2, 3));
+    };
+
+    logic.Start();
+
+    onStartCalled.ShouldBeTrue();
+    looped.ShouldBeFalse();
+  }
+
   [Fact]
   public void StopExitsState() {
     var exitCalled = false;

Chickensoft.LogicBlocks/src/LogicBlock.cs

@@ -400,10 +400,10 @@ internal TState ProcessInputs<TInputType>(
 
     if (_value is null) {
       // No state yet. Let's get the first state going!
-      OnStart();
       Blackboard.InstantiateAnyMissingSavedData();
       ChangeState(RestoredState as TState ?? GetInitialState().State);
       RestoredState = null;
+      OnStart();
     }
 
     // We can always process the first input directly.