Merge pull request #2849 from lemonlambda/lemon

Removed `[A]ll - yes to all`

Author: gep13

src/chocolatey.tests/infrastructure/commandline/InteractivePromptSpecs.cs

@@ -666,7 +666,7 @@ public class When_prompting_answer_with_dash_with_interactivePrompt : Interactiv
             public override void Context()
             {
                 base.Context();
-                Choices.Add("all - yes to all");
+                Choices.Add("all scripts");
             }
 
             public override void Because()
@@ -683,17 +683,9 @@ public override void AfterObservations()
             [Fact]
             public void Should_return_all_when_full_all_answer_is_given()
             {
-                Console.Setup(c => c.ReadLine()).Returns("all - yes to all");
+                Console.Setup(c => c.ReadLine()).Returns("all scripts");
                 var result = _prompt();
-                result.Should().Be("all - yes to all");
-            }
-
-            [Fact]
-            public void Should_return_all_when_only_all_is_given()
-            {
-                Console.Setup(c => c.ReadLine()).Returns("all");
-                var result = _prompt();
-                result.Should().Be("all - yes to all");
+                result.Should().Be("all scripts");
             }
         }
     }

src/chocolatey/infrastructure.app/configuration/ChocolateyConfiguration.cs

@@ -125,7 +125,7 @@ public void RevertChanges(bool removeBackup = false)
                     if (property.Name == "PromptForConfirmation")
                     {
                         // We do not overwrite this value between backups as it is intended to be a global setting;
-                        // if a user has selected a "[A] yes to all" prompt interactively, this option is
+                        // if a user has selected a "[A]ll scripts" prompt interactively, this option is
                         // set and should be retained for the duration of the operations.
                         continue;
                     }

src/chocolatey/infrastructure.app/services/PowershellService.cs

@@ -279,7 +279,7 @@ public bool RunAction(ChocolateyConfiguration configuration, PackageResult packa
                         this.Log().Info(ChocolateyLoggers.Important, () => @"choco feature enable -n allowGlobalConfirmation");
 
                         var selection = InteractivePrompt.PromptForConfirmation(@"Do you want to run the script?",
-                            new[] { "yes", "all - yes to all", "no", "print" },
+                            new[] { "yes", "all scripts", "no", "print" },
                             defaultChoice: null,
                             requireAnswer: true,
                             allowShortAnswer: true,
@@ -305,7 +305,7 @@ public bool RunAction(ChocolateyConfiguration configuration, PackageResult packa
                             shouldRun = true;
                         }
 
-                        if (selection.IsEqualTo("all - yes to all"))
+                        if (selection.IsEqualTo("all scripts"))
                         {
                             configuration.PromptForConfirmation = false;
                             shouldRun = true;

tests/pester-tests/commands/choco-install.Tests.ps1

@@ -1704,8 +1704,8 @@ To install a local, or remote file, you may use:
             }
         }
 
-        It "Ran both installation scripts after selecting [A] Yes to all at the first prompt" {
-            $promptLine = "Do you want to run the script?([Y]es/[A]ll - yes to all/[N]o/[P]rint):"
+        It "Ran both installation scripts after selecting [A]ll scripts at the first prompt" {
+            $promptLine = "Do you want to run the script?([Y]es/[A]ll scripts/[N]o/[P]rint):"
             $prompts = $Output.Lines | Where-Object { $_ -eq $promptLine }
 
             $prompts.Count | Should -Be 1