chore: complete Node.js upgrade — CircleCI and Netlify #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for chrisvogt failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 67 67
Lines 669 669
Branches 189 189
=======================================
Hits 639 639
Misses 26 26
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the Node.js upgrade to v22 across local environment settings and CI pipelines.
- Adds
.nvmrcspecifying Node v22.15 for consistency in local and Netlify builds - Updates CircleCI Docker image to
cimg/node:22.15for pipeline alignment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .nvmrc | Introduces Node version 22.15 for NVM and Netlify UI |
| .circleci/config.yml | Bumps CircleCI Docker image from Node 20.9.0 to 22.15 |
Comments suppressed due to low confidence (1)
.nvmrc:1
- [nitpick] Make sure to update the project documentation (README, contributing guide, etc.) to mention the Node.js version bump to 22.15 to keep docs in sync.
22.15
| @@ -3,7 +3,7 @@ version: 2.1 | |||
| jobs: | |||
| build: | |||
| docker: | |||
| - image: cimg/node:20.9.0 # Updated to Node 20.9.0 | |||
| - image: cimg/node:22.15 | |||
There was a problem hiding this comment.
[nitpick] Consider adding or updating an inline comment to reflect the new Node version (e.g., # Updated to Node 22.15) for clarity and consistency.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the upgrade started with #290. I've upgraded the Node.js version in the Netlify UI so that the next deploys use v22, and this also upgrades the Docker image used for CircleCI.