feat: add skip to content link for keyboard-first visitors #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chrisvogt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 76 76
Lines 888 889 +1
Branches 242 243 +1
=======================================
+ Hits 858 859 +1
Misses 26 26
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The deploy preview looks great. I'm going to merge this. Screen.Recording.2025-06-23.at.8.47.02.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reattempts #212 and adds a skip navigation link to the home and page templates.
AI summary
This pull request introduces a new accessibility feature, a "Skip to content" link, for improved navigation by keyboard-first users. It also includes related updates to the codebase, tests, and documentation. Below is a breakdown of the most important changes grouped by theme.
Accessibility Feature: "Skip to Content" Link
SkipNavLinkandSkipNavContentcomponents from the@reach/skip-navlibrary to theLayoutandHomeTemplatecomponents, enabling users to skip directly to the main content. (theme/src/components/layout.js,theme/src/templates/home.js) [1] [2] [3] [4] [5]@reach/skip-nav/styles.cssingatsby-browser.js. (theme/gatsby-browser.js)Navigation Behavior Enhancements
onRouteUpdatefunction to focus the main content (SkipNavContent) after a route change, improving accessibility for keyboard users. (theme/gatsby-browser.js)Testing
shouldUpdateScrollandonRouteUpdatefunctions, including mock implementations for DOM manipulation. (theme/gatsby-browser.spec.js)Documentation and Versioning
CHANGELOG.mdto document the new feature in version0.45.0. (CHANGELOG.md)package.jsonversion to0.45.0and added@reach/skip-navas a dependency. (theme/package.json) [1] [2]Snapshot Updates
SkipNavContentelement. (theme/src/components/__snapshots__/layout.spec.js.snap) [1] [2] [3]