Add File System Access showOpenFilePicker #137
Conversation
| displayOutcome( | ||
| "open-file-picker", | ||
| "error", | ||
| )("window.showOpenFilePicker not available"); |
There was a problem hiding this comment.
Looks like this logging is actually broken. I've pushed a separate fix: 144752c
There was a problem hiding this comment.
Thanks, checking in, this is resolved now?
index.html
Outdated
| <button id="eme">Encrypted Media (EME)</button> | ||
| <button id="idle-detection">Idle Detection</button> | ||
| <button id="persistent-storage">Persistent Storage</button> | ||
| <button id="open-file-picker">Open File Picker</button> |
There was a problem hiding this comment.
Arguably it might make sense to match the API names and use "show" instead of "open", but I personally don't feel strongly.
There was a problem hiding this comment.
uh, I guess this more specifically applies to .showDirectoryPicker(…) (which does not contain "open").
There was a problem hiding this comment.
Updated to use method names verbatim.
|
Updates made, ready for re-review. |
|
Thanks, I don't have close + squash access on that repo. |
I should be able to merge! |
No description provided.