Skip to content

add simple support for pending and skipped steps in spinach #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add simple support for pending and skipped steps in spinach #4

wants to merge 2 commits into from

Conversation

JohnBat26
Copy link

No description provided.

@shepmaster
Copy link
Member

Thanks for the PR!

I cannot accept it as-is however:

  1. You say that this adds support for both pending and skipped, but the commit only adds code for pending. Your messages and code need to be consistent.
  2. You will also need to add tests for the new cases you want to support.

Let me know how we can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnBat26 @shepmaster