Add feature level error handling #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where a feature level error happens (such as no feature definition can be found) the original implementation will not be able to catch the error (rather just an empty XML file). This makes debug really hard since no error info is shown. This commit meant to fix the situation by implementing `on_feature_not_found`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for the PR
In the case where a feature level error happens (such as no feature definition can be found) the original implementation will not be able to catch the error (rather just an empty XML file). This makes debug really hard since no error info is shown. This commit meant to fix the situation by implementing
on_feature_not_foundMIscs
I dropped the 1.9.3 support. Please let me know if yo want to add it back. I will take a closer look on why the build is failing on 1.9.3. Thanks!