refactor: deployment scripts and commands (#12)

## Summary
Improve the quality of `scripts/`. 

## Detail
### Changeset
* add linting for scripts/
* add deployment and verify command for legacy
`DeployTokenCallbackPlugin`

### Checklist
- [x] Did you add new tests and confirm all tests pass? (`yarn test`)
- [ ] Did you update relevant docs? (docs are found in the `docs`
folder)
- [x] Do your commits follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [x] Does your PR title also follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [ ] If you have a breaking change, is it [correctly reflected in your
commit
message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g.
`feat!: breaking change`)
- [x] Did you run lint (`yarn lint`) and fix any issues?
- [x] Did you run formatter (`yarn format:check`) and fix any issues
(`yarn format:write`)?

## Testing
No impact.

## Documentation
n/a

Author: huaweigu

.solhint-script.json

@@ -0,0 +1,8 @@
+{
+  "extends": "solhint:recommended",
+  "rules": {
+    "compiler-version": ["error", "0.8.24"],
+    "func-visibility": ["error", { "ignoreConstructors": true }],
+    "no-console": "off"
+  }
+}

package.json

@@ -5,7 +5,7 @@
   "scripts": {
     "clean": "rm -rf cache artifacts typechain-types",
     "build": "forge build",
-    "lint": "solhint -w 130 -c .solhint-src.json './src/**/*.sol' && solhint -w 245 -c .solhint-test.json './test/**/*.sol'",
+    "lint": "solhint -w 127 -c .solhint-src.json './src/**/*.sol' && solhint -w 242 -c .solhint-test.json './test/**/*.sol' && solhint -w 0 -c .solhint-script.json './script/**/*.sol'",
     "test": "forge test -vv",
     "gasreport": "forge test --gas-report > gas/reports/gas-report.txt",
     "coverage": "forge coverage --ir-minimum",

script/001_DeployPluginManager.s.sol

@@ -24,7 +24,7 @@ import {PLUGIN_MANAGER_ADDRESS} from "./000_ContractAddress.sol";
 import {Script, console} from "forge-std/src/Script.sol";
 
 contract DeployPluginManagerScript is Script {
-    address EXPECTED_PLUGIN_MANAGER = PLUGIN_MANAGER_ADDRESS;
+    address internal constant EXPECTED_PLUGIN_MANAGER = PLUGIN_MANAGER_ADDRESS;
 
     function run() public {
         uint256 deployerKey = vm.envUint("DEPLOYER_PRIVATE_KEY");

script/002_DeployUpgradableMSCAFactory.s.sol

@@ -24,9 +24,9 @@ import {ENTRY_POINT, PLUGIN_MANAGER_ADDRESS, UPGRADABLE_MSCA_FACTORY_ADDRESS} fr
 import {Script, console} from "forge-std/src/Script.sol";
 
 contract DeployUpgradableMSCAFactoryScript is Script {
-    address OWNER = vm.envAddress("MSCA_FACTORY_OWNER_ADDRESS");
-    address PLUGIN_MANAGER = PLUGIN_MANAGER_ADDRESS;
-    address payable EXPECTED_FACTORY_ADDRESS = payable(UPGRADABLE_MSCA_FACTORY_ADDRESS);
+    address internal constant PLUGIN_MANAGER = PLUGIN_MANAGER_ADDRESS;
+    address payable internal constant EXPECTED_FACTORY_ADDRESS = payable(UPGRADABLE_MSCA_FACTORY_ADDRESS);
+    address internal owner = vm.envAddress("MSCA_FACTORY_OWNER_ADDRESS");
 
     function run() public {
         address entryPoint = ENTRY_POINT;
@@ -36,7 +36,7 @@ contract DeployUpgradableMSCAFactoryScript is Script {
 
         UpgradableMSCAFactory factory;
         if (EXPECTED_FACTORY_ADDRESS.code.length == 0) {
-            factory = new UpgradableMSCAFactory{salt: 0}(OWNER, entryPoint, PLUGIN_MANAGER);
+            factory = new UpgradableMSCAFactory{salt: 0}(owner, entryPoint, PLUGIN_MANAGER);
             console.log("Deployed new factory at address: %s", address(factory));
         } else {
             factory = UpgradableMSCAFactory(EXPECTED_FACTORY_ADDRESS);

script/003_DeploySingleOwnerMSCAFactory.s.sol

@@ -18,12 +18,13 @@
  */
 pragma solidity 0.8.24;
 
-import "../src/msca/6900/v0.7/factories/semi/SingleOwnerMSCAFactory.sol";
-import "forge-std/src/Script.sol";
+import {SingleOwnerMSCAFactory} from "../src/msca/6900/v0.7/factories/semi/SingleOwnerMSCAFactory.sol";
+import {Script, console} from "forge-std/src/Script.sol";
 
 contract DeploySingleOwnerMSCAFactoryScript is Script {
-    address constant PLUGIN_MANAGER = 0xc751A2bFA2A4a5b27E94ad735534c16a0999d871;
-    address payable constant EXPECTED_FACTORY_ADDRESS = payable(address(0x1a1f5310eD7fF0B84Cef7E6d7D0f94Cc16D23013));
+    address internal constant PLUGIN_MANAGER = 0xc751A2bFA2A4a5b27E94ad735534c16a0999d871;
+    address payable internal constant EXPECTED_FACTORY_ADDRESS =
+        payable(address(0x1a1f5310eD7fF0B84Cef7E6d7D0f94Cc16D23013));
 
     function run() public {
         address entryPoint = vm.envAddress("ENTRY_POINT");

script/004_DeploySingleOwnerPlugin.s.sol

@@ -18,13 +18,13 @@
  */
 pragma solidity 0.8.24;
 
-import "../src/msca/6900/v0.7/plugins/v1_0_0/acl/SingleOwnerPlugin.sol";
+import {SingleOwnerPlugin} from "../src/msca/6900/v0.7/plugins/v1_0_0/acl/SingleOwnerPlugin.sol";
 
 import {SINGLE_OWNER_PLUGIN_ADDRESS} from "./000_ContractAddress.sol";
-import "forge-std/src/Script.sol";
+import {Script, console} from "forge-std/src/Script.sol";
 
 contract DeploySingleOwnerPluginScript is Script {
-    address payable EXPECTED_PLUGIN_ADDRESS = payable(SINGLE_OWNER_PLUGIN_ADDRESS);
+    address payable internal constant EXPECTED_PLUGIN_ADDRESS = payable(SINGLE_OWNER_PLUGIN_ADDRESS);
 
     function run() public {
         uint256 key = vm.envUint("DEPLOYER_PRIVATE_KEY");

script/005_DeployECDSAAccountFactory.s.sol

@@ -18,14 +18,16 @@
  */
 pragma solidity 0.8.24;
 
-import "../src/account/v1/factory/ECDSAAccountFactory.sol";
-import "forge-std/src/Script.sol";
+import {ECDSAAccountFactory} from "../src/account/v1/factory/ECDSAAccountFactory.sol";
+
+import {IEntryPoint} from "@account-abstraction/contracts/interfaces/IEntryPoint.sol";
+import {Script, console} from "forge-std/src/Script.sol";
 
 /// @dev We actually still used hardhat deployment for this legacy contract. This script is more for convenience
 /// purpose.
 contract DeployECDSAAccountFactoryScript is Script {
-    // TODO: replace this with officially deployed address
-    address payable constant EXPECTED_FACTORY_ADDRESS = payable(address(0x39c09e93D074782C5ffc45da27910c14C628a183));
+    address payable internal constant EXPECTED_FACTORY_ADDRESS =
+        payable(address(0x39c09e93D074782C5ffc45da27910c14C628a183));
 
     function run() public {
         address entryPoint = vm.envAddress("ENTRY_POINT");

script/006_DeployAddressBookPlugin.s.sol

@@ -24,8 +24,8 @@ import {console} from "forge-std/src/console.sol";
 
 // Deprecated
 contract DeployAddressBookPluginScript is Script {
-    // TODO: replace this with officially deployed address
-    address payable constant EXPECTED_PLUGIN_ADDRESS = payable(address(0x1E0689ae0171CcFbE9E7C7491B1eb09e0D5b7103));
+    address payable internal constant EXPECTED_PLUGIN_ADDRESS =
+        payable(address(0x1E0689ae0171CcFbE9E7C7491B1eb09e0D5b7103));
 
     function run() public {
         uint256 key = vm.envUint("DEPLOYER_PRIVATE_KEY");

script/007_DeployColdStorageAddressBookPlugin.s.sol

@@ -26,7 +26,7 @@ import {Script} from "forge-std/src/Script.sol";
 import {console} from "forge-std/src/console.sol";
 
 contract DeployColdStorageAddressBookPluginScript is Script {
-    address payable EXPECTED_PLUGIN_ADDRESS = payable(COLD_STORAGE_ADDRESS_BOOK_PLUGIN_ADDRESS);
+    address payable internal constant EXPECTED_PLUGIN_ADDRESS = payable(COLD_STORAGE_ADDRESS_BOOK_PLUGIN_ADDRESS);
 
     function run() public {
         uint256 key = vm.envUint("DEPLOYER_PRIVATE_KEY");

script/008_DeployWeightedWebauthnMultisigPlugin.s.sol

@@ -26,7 +26,7 @@ import {Script} from "forge-std/src/Script.sol";
 import {console} from "forge-std/src/console.sol";
 
 contract DeployWeightedWebauthnMultisigPlugin is Script {
-    address payable EXPECTED_PLUGIN_ADDRESS = payable(WEIGHTED_MULTISIG_PLUGIN_ADDRESS);
+    address payable internal constant EXPECTED_PLUGIN_ADDRESS = payable(WEIGHTED_MULTISIG_PLUGIN_ADDRESS);
 
     function run() public {
         address entryPoint = ENTRY_POINT;