Skip to content

Commit c5d732b

Browse files
committed
fix comments
1 parent aa01aa1 commit c5d732b

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

script/bytecode-deploy/100_Constants.sol

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,15 @@ library Constants {
4444
"op"
4545
];
4646
}
47+
48+
// A list of chains that need to run setup work after deployment. Please adjust the list based on the chain
49+
// expansion needs.
50+
function getChainsForSetup() internal pure returns (string[4] memory) {
51+
return [
52+
"base-sepolia",
53+
"base",
54+
"op-sepolia",
55+
"op"
56+
];
57+
}
4758
}

script/bytecode-deploy/105_SetUpgradableMSCAFactoryPlugins.s.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ pragma solidity 0.8.24;
2020

2121
import {UpgradableMSCAFactory} from "../../src/msca/6900/v0.7/factories/UpgradableMSCAFactory.sol";
2222
import {
23+
Constants,
2324
COLD_STORAGE_ADDRESS_BOOK_PLUGIN_ADDRESS,
2425
UPGRADABLE_MSCA_FACTORY_ADDRESS,
2526
WEIGHTED_MULTISIG_PLUGIN_ADDRESS
@@ -44,8 +45,7 @@ contract SetUpgradableMSCAFactoryPlugins is Script {
4445
pluginPermissions[i] = true;
4546
}
4647

47-
// NOTE: Please adjust the chain list based on the chain expansion needs.
48-
string[4] memory chains = ["base", "op", "base-sepolia", "op-sepolia"];
48+
string[4] memory chains = Constants.getChainsForSetup();
4949

5050
// Set plugins for factory
5151
for (uint256 i = 0; i < chains.length; i++) {

script/bytecode-deploy/106_StakeUpgradableMSCAFactory.s.sol

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pragma solidity 0.8.24;
2020

2121
import {UpgradableMSCAFactory} from "../../src/msca/6900/v0.7/factories/UpgradableMSCAFactory.sol";
2222

23-
import {UPGRADABLE_MSCA_FACTORY_ADDRESS} from "./100_Constants.sol";
23+
import {Constants, UPGRADABLE_MSCA_FACTORY_ADDRESS} from "./100_Constants.sol";
2424
import {Script, console} from "forge-std/src/Script.sol";
2525

2626
contract StakeUpgradableMSCAFactory is Script {
@@ -30,10 +30,10 @@ contract StakeUpgradableMSCAFactory is Script {
3030
uint256 key = vm.envUint("MSCA_FACTORY_OWNER_PRIVATE_KEY");
3131

3232
uint32 unstakeDelaySec = 1 * 24 * 60 * 60; // 1 day
33+
string[4] memory chains = Constants.getChainsForSetup();
3334

34-
// NOTE: Please adjust the chain list based on the chain expansion needs, and configure stake value based on
35-
// minimums from https://docs.alchemy.com/docs/bundler-services#minimum-stake
36-
string[4] memory chains = ["base", "op", "base-sepolia", "op-sepolia"];
35+
// NOTE: Please configure stake value based on minimums from
36+
// https://docs.alchemy.com/docs/bundler-services#minimum-stake
3737
uint64[4] memory stakeValue = [0.1 ether, 0.1 ether, 0.1 ether, 0.1 ether];
3838

3939
// Set plugins for factory

0 commit comments

Comments
 (0)