Skip to content

Conversation

huaweigu
Copy link
Contributor

@huaweigu huaweigu commented Nov 4, 2024

Summary

  • updated v1 MSCA and plugins
  • updated v2 MSCA and modules (WIP)

Detail

Changeset

  • v1 MSCA and plugins
    • fix warnings
    • enshrine DefaultCallbackHandler
  • v2 MSCA and modules (WIP)
    • new progress on 6900 v0.8 accounts and modules

Checklist

  • Did you add new tests and confirm all tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the docs folder)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint) and fix any issues?
  • Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

Testing

  • Tests have been added & updated
  • Coverage has also been re-enabled

Documentation

n/a

@huaweigu huaweigu force-pushed the feat/sync branch 6 times, most recently from 124936c to 4d7be91 Compare November 4, 2024 23:45
@huaweigu huaweigu marked this pull request as draft November 5, 2024 00:05
@huaweigu huaweigu force-pushed the feat/sync branch 14 times, most recently from b652b5f to 9512381 Compare November 6, 2024 15:57
* v1 MSCA and plugins
* v2 MSCA and modules (WIP)
@huaweigu huaweigu marked this pull request as ready for review November 6, 2024 17:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you guys think it would make sense to have all of these changes on a branch separate from master (maybe something like erc-6900-v0.8) to indicate that these changes are unaudited / still in development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work of v0.8 is in a separate package and doesn't affect other live contracts such as v0.7. Also, v0.8 development is close to finish. We can try the branching idea next time if needed.

@huaweigu huaweigu merged commit c0129bc into circlefin:master Nov 6, 2024
6 checks passed
@huaweigu huaweigu deleted the feat/sync branch November 6, 2024 21:28
huaweigu pushed a commit that referenced this pull request Nov 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.0...v2.1.0)
(2024-11-07)


### Features

* update contracts
([#41](#41))
([c0129bc](c0129bc))


### Documentation

* Add verification instructions for proxy accounts
([#38](#38))
([d395e5e](d395e5e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants