build: test out new dependency review action #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaweigu
changed the title
ZhiyuCircle
reviewed
Nov 7, 2024
| "forge-std": "github:foundry-rs/forge-std#v1.9.2", | ||
| "solady": "0.0.243", | ||
| "erc6900-reference-implementation": "0.8.0-rc.6" | ||
| "@erc6900/reference-implementation": "github:erc6900/reference-implementation#v0.8.0-rc.6" |
There was a problem hiding this comment.
ok, this reverts back to github package
ZhiyuCircle
approved these changes
Nov 7, 2024
ZhiyuCircle
reviewed
Nov 7, 2024
| run: yarn test | ||
|
|
||
| scan: | ||
| needs: lint_and_test |
There was a problem hiding this comment.
yes removing needs: lint_and_test to speed up the build per recommendation from Jake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test out the new public dependency review action. We actually want to revert back to github package as node release is not maintained by any teams now. There're also discussions related to getting the org scope (
@erc6900) back. So I think we should stick with github package for the time being.Detail
Changeset
needs: lint_and_testto speed up the buildChecklist
yarn test)docsfolder)feat!: breaking change)yarn lint) and fix any issues?yarn format:check) and fix any issues (yarn format:write)?Testing
No features have been added, so just existing tests.
Documentation
n/a