Skip to content

build: test out new dependency review action #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024
Merged

build: test out new dependency review action #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bfdf1b
chore: test out new depedency review action
huaweigu Nov 6, 2024
f4169d9
chore: ignore yarn lock
huaweigu Nov 6, 2024
67e55c2
build: remove unnecessary dep to run scan early
huaweigu Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,5 @@ jobs:
run: yarn test

scan:
needs: lint_and_test
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ok to remove this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes removing needs: lint_and_test to speed up the build per recommendation from Jake

if: github.event_name == 'pull_request'
uses: circlefin/circle-public-github-workflows/.github/workflows/pr-scan.yaml@v1
3 changes: 2 additions & 1 deletion .licenseignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# GPL-3.0
pkg:npm/erc6900-reference-implementation
pkg:npm/%40erc6900/reference-implementation
pkg:github/erc6900/reference-implementation
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"fcl": "github:rdubois-crypto/FreshCryptoLib#8179e08cac72072bd260796633fec41fdfd5b441",
"forge-std": "github:foundry-rs/forge-std#v1.9.2",
"solady": "0.0.243",
"erc6900-reference-implementation": "0.8.0-rc.6"
"@erc6900/reference-implementation": "github:erc6900/reference-implementation#v0.8.0-rc.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this reverts back to github package

},
"devDependencies": {
"solhint": "^5.0.3"
Expand Down
2 changes: 1 addition & 1 deletion remappings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
@solady/=node_modules/solady/src/
@fcl/=node_modules/fcl/solidity/src/
forge-std/=node_modules/forge-std/
@erc6900/reference-implementation/=node_modules/erc6900-reference-implementation/src/
@erc6900/reference-implementation/=node_modules/@erc6900/reference-implementation/src/
@eth-infinitism/account-abstraction/=lib/account-abstraction/contracts/
9 changes: 4 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
js-tokens "^4.0.0"
picocolors "^1.0.0"

"@erc6900/reference-implementation@github:erc6900/reference-implementation#v0.8.0-rc.6":
version "0.8.0-rc.5"
resolved "https://codeload.github.com/erc6900/reference-implementation/tar.gz/6cdcfa653eb019d27d23586a86ff8171201a4066"

"@modular-account-libs@github:erc6900/modular-account-libs#v0.8.0-rc.0":
version "0.8.0-rc.0"
resolved "https://codeload.github.com/erc6900/modular-account-libs/tar.gz/d64adb5bd100d6ad64d0a83b5dc13b356423d852"
Expand Down Expand Up @@ -262,11 +266,6 @@ emoji-regex@^8.0.0:
resolved "https://registry.yarnpkg.com/emoji-regex/-/emoji-regex-8.0.0.tgz#e818fd69ce5ccfcb404594f842963bf53164cc37"
integrity sha512-MSjYzcWNOA0ewAHpz0MxpYFvwg6yjy1NG3xteoqz644VCo/RPgnr1/GGt+ic3iJTzQ8Eu3TdM14SawnVUmGE6A==

erc6900-reference-implementation@0.8.0-rc.6:
version "0.8.0-rc.6"
resolved "https://registry.yarnpkg.com/erc6900-reference-implementation/-/erc6900-reference-implementation-0.8.0-rc.6.tgz#57b91eefe9b1f9db05f2508efb452ec36388da41"
integrity sha512-Wc/lG0WosOMxZX+iZSGBfN9KQ5SLuyjooPc8e1BljLuDDDn9yViOEB+szHAoy2AQswwo6xJ3cvDEo035hCndJg==

error-ex@^1.3.1:
version "1.3.2"
resolved "https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.2.tgz#b4ac40648107fdcdcfae242f428bea8a14d4f1bf"
Expand Down
Loading