ci: add code coverage checking script #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaweigu
reviewed
Jan 29, 2025
| // TODO: uncomment line once source code coverages have been bumped up | ||
| // process.exit(2); | ||
| } | ||
| })(); No newline at end of file |
There was a problem hiding this comment.
Actually you can fix this when the threshold is enforced
huaweigu
reviewed
Jan 29, 2025
|
@huaweigu yes, should be good to merge 👍 |
huaweigu
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
huaweigu
pushed a commit
that referenced
this pull request
Feb 21, 2025
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.2...v2.2.0) (2025-02-20) ### Features * add bytecode deployment scripts ([#68](#68)) ([a0fdf60](a0fdf60)) * sync the latest development ([#72](#72)) ([4e6281f](4e6281f)) ### Miscellaneous Chores * add missing copyright header ([#70](#70)) ([431adb9](431adb9)) ### Continuous Integration * add code coverage checking script ([#58](#58)) ([517b89a](517b89a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add code coverage checking script.
Detail
Add a script that checks that the coverage of each files matches our minimum defined threshold. Currently, the script doesn't fail. Once you files meet our defined threshold, we can uncomment the line tht will make the script start failing.
Checklist
yarn test)docsfolder)feat!: breaking change)yarn lint) and fix any issues?yarn format:check) and fix any issues (yarn format:write)?Testing
See
Coverage -> run_coverage (pull_request) -> Run Test Coveragejob logs in latest PR build.