feat: Add bytecode deployment script

[weikangsong]

Summary

Adds deployment script based on bytecode deployment with deterministic deployment factory

Detail

We're hitting a solidity issue when using existing deployment script for circle_6900_v1 contract deployment. We decided to use bytecode deployment instead.

I tried ai cli for code review but hitting 500 error from openai, thread: https://circlefin.slack.com/archives/C087VN6JYRW/p1739470622423289

Changeset

This PR:

1. Adds deployment scripts for circle_6900_v1 contracts
2. Deployment script support multi-chain deploy.
3. Adds README for how the scripts and artifacts are generated, as well as the future chain expansion instructions.

Checklist

• Did you add new tests and confirm all tests pass? (yarn test)
• Did you update relevant docs? (docs are found in the docs folder)
• Do your commits follow the Conventional Commits standard?
• Does your PR title also follow the Conventional Commits standard?
• If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
• Did you run lint (yarn lint) and fix any issues?
• Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

Testing

Mandatory section.
For each changeset, please highlight the tests you've added.

N/A no need to create test files for deployment scripts

Documentation

Optional section.
Link to the doc.

[huaweigu]

I think we can reuse [the same script](https://github.com/circlefin/buidl-wallet-contracts/tree/master/script) and include "V2" in the file name. For the new contracts, this bytecode deployment approach will be the default.

[huaweigu]

Reuse https://github.com/circlefin/buidl-wallet-contracts/blob/master/script/000_ContractAddress.sol?

[weikangsong]

I'd like to keep /bytecode-deploy separate from existing scripts and avoid making changes to existing scripts

[huaweigu]

add this to https://github.com/circlefin/buidl-wallet-contracts/blob/master/script/000_ContractAddress.sol?

[weikangsong]

Done

[huaweigu]

make this configurable?
getSaltFromEnvOrDefault - if the env has overridden value, then use it, otherwise default to a value 0.

[weikangsong]

I used a salt mined for 7 leading zeros on the address, it's better to leave it in each deployment script since they're contract bytecode specific.

[huaweigu]

ditto

[huaweigu]

Please also fill in the PR description when it's moved to "ready for review".

[huaweigu]

could add this to a new Errors.sol and share it across scripts

[weikangsong]

Done

[huaweigu]

maybe also add a readme here how we generate this file so others can follow

[weikangsong]

I added to main readme, does that work for you?

[huaweigu]

Can you at least use the same naming convention from other scripts?

…

On Tue, Feb 4, 2025, 6:22 PM weikangsong ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In script/bytecode-deploy/100_ContractAddress.sol <https://urldefense.com/v3/__https://github.com/circlefin/buidl-wallet-contracts/pull/68*discussion_r1942026118__;Iw!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYubz8rqyH$> : > + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/ <https://urldefense.com/v3/__http://www.gnu.org/licenses/__;!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYuV-x2szb$>>. + */ +pragma solidity 0.8.24; + +address constant ENTRY_POINT = 0x0000000071727De22E5E9d8BAf0edAc6f37da032; I'd like to keep /bytecode-deploy separate from existing scripts and avoid making changes to existing scripts — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/circlefin/buidl-wallet-contracts/pull/68*discussion_r1942026118__;Iw!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYubz8rqyH$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACELT73QQG6HZEQ25G5ST4D2OFDC7AVCNFSM6AAAAABWMYGVBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJUGI3TINRVG4__;!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYueEbjR26$> . You are receiving this because you commented.Message ID: ***@***.***>

[huaweigu]

Any specific reason we're not starting from 001 for the file name?

[weikangsong]

yeah because foundry generates folder under ./broadcast based on script name.. if using 001, it will be conflict with existing scripts

[weikangsong]

Can you at least use the same naming convention from other scripts?
…
On Tue, Feb 4, 2025, 6:22 PM weikangsong @.> wrote: @.* commented on this pull request. ------------------------------ In script/bytecode-deploy/100_ContractAddress.sol https://urldefense.com/v3/__https://github.com/circlefin/buidl-wallet-contracts/pull/68*discussion_r1942026118__;Iw!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYubz8rqyH$ : > + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/ https://urldefense.com/v3/__http://www.gnu.org/licenses/__;!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYuV-x2szb$>. + / +pragma solidity 0.8.24; + +address constant ENTRY_POINT = 0x0000000071727De22E5E9d8BAf0edAc6f37da032; I'd like to keep /bytecode-deploy separate from existing scripts and avoid making changes to existing scripts — Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/circlefin/buidl-wallet-contracts/pull/68*discussion_r1942026118__;Iw!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYubz8rqyH$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACELT73QQG6HZEQ25G5ST4D2OFDC7AVCNFSM6AAAAABWMYGVBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJUGI3TINRVG4__;!!KESPuB0hxvuP98OfPa165uRs!BwoIR_xSxQqXAr-qtFw7uGMqNcuL8KGhwva6fq-wp9tfjuiKYS9BO0HrM744ca12QAQ3aYwe_bpYueEbjR26$ . You are receiving this because you commented.Message ID: @.**>

what is the naming convention you're referring to?

[huaweigu]

Let's move the deployment and verification instructions to a separate README to keep the main README concise. In the main README, we can include a reference to the deployment README.