feat: Deploy UpgradableMSCAFactory to base & op #74
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR deploys the UpgradableMSCAFactory to base and op networks by updating the deployment scripts and configuration.
- Added new RPC URL entries for base and op networks, including Sepolia testnet support
- Updated foundry.toml with chain-specific variables to enable deployment on these networks
Files not reviewed (12)
- .env.example: Language not supported
- broadcast/multi/103_DeployColdStorageAddressBookPlugin.s.sol-1741910918/run.json: Language not supported
- broadcast/multi/105_SetUpgradableMSCAFactoryPlugins.s.sol-1742255976/run.json: Language not supported
- broadcast/multi/105_SetUpgradableMSCAFactoryPlugins.s.sol-latest/run.json: Language not supported
- broadcast/multi/106_StakeUpgradableMSCAFactory.s.sol-1742256374/run.json: Language not supported
- script/bytecode-deploy/100_Constants.sol: Language not supported
- script/bytecode-deploy/101_DeployPluginManager.s.sol: Language not supported
- script/bytecode-deploy/102_DeployUpgradableMSCAFactory.s.sol: Language not supported
- script/bytecode-deploy/103_DeployColdStorageAddressBookPlugin.s.sol: Language not supported
- script/bytecode-deploy/104_DeployWeightedWebauthnMultisigPlugin.s.sol: Language not supported
- script/bytecode-deploy/105_SetUpgradableMSCAFactoryPlugins.s.sol: Language not supported
- script/bytecode-deploy/106_StakeUpgradableMSCAFactory.s.sol: Language not supported
|
|
||
| // NOTE: Please adjust the chain list based on the chain expansion needs, and configure stake value based on | ||
| // minimums from https://docs.alchemy.com/docs/bundler-services#minimum-stake | ||
| string[4] memory chains = ["base", "op", "base-sepolia", "op-sepolia"]; |
There was a problem hiding this comment.
Minor suggestion: We can define chains in a parent contract (e.g., ChainExpansion) to avoid redefining them repeatedly.
There was a problem hiding this comment.
Added a getChainsForSetup in Constants and reference that in this and below script
| @@ -3,7 +3,7 @@ | |||
| { | |||
| "transactions": [ | |||
| { | |||
| "hash": "0x58a37f1a3308b926f7d4a479c4b4a31b0998202e134439e26882e8a1639dd74b", | |||
| "hash": "0x290dc114bda3fdbb638e84399acdb602d0050c3dc68cf530ad5e23a4aac33372", | |||
There was a problem hiding this comment.
Just to clarify, ColdStorageAddressBookPlugin is re-deployed?
There was a problem hiding this comment.
No - if you look at below, this transaction is in a different chain. The order of transactions is auto-generated and seems re-ordered a bit.
There was a problem hiding this comment.
Okay, in the case of re-ordering, the transaction 0x58a37f1a3308b926f7d4a479c4b4a31b0998202e134439e26882e8a1639dd74b should still exist after this PR, correct? I'm not sure why it's missing in this file](https://github.com/circlefin/buidl-wallet-contracts/blob/8cc42caeb2efaa169e219a1f38029517a074bb23/broadcast/multi/103_DeployColdStorageAddressBookPlugin.s.sol-latest/run.json). I'll sync up with you offline.
| @@ -3,7 +3,7 @@ | |||
| { | |||
| "transactions": [ | |||
| { | |||
| "hash": "0x7d8d040bfc26e99109b432712fea8cd16662cab3b8f45ccde50564a2bcdeeabe", | |||
| "hash": "0x6be1cf49f4a1912b3ee9cdd36d9cc5a2b906289bc4ed159a268da5815aeb314f", | |||
| @@ -3,7 +3,7 @@ | |||
| { | |||
| "transactions": [ | |||
| { | |||
| "hash": "0xfd6f64d975dd1829a7729e9b60d178f873a3a7c688e3b943e28f90119ffc0730", | |||
| "hash": "0xa96b5045833bd2b5a4c6b4de74d02c64adc63d12407c66e09a38243bb2fd50d0", | |||
There was a problem hiding this comment.
Just to clarify, PluginManager is re-deployed?
Summary
Deploy UpgradableMSCAFactory to base & op
Detail
Changeset
Checklist
yarn test)yarn coverage)docsfolder)yarn lint) and fix any issues?yarn format:check) and fix any issues (yarn format:write)?Testing
Not applicable for chain expansion since no new contracts are added.
Documentation
Optional section.
Link to the doc.