Skip to content

Conversation

weikangsong
Copy link
Contributor

@weikangsong weikangsong commented May 3, 2025

Summary

Update chain expansion guide in README for EP v0.6 branch

Detail

Changeset

Update README with a comprehensive "Chain Expansion Guide". main branch PR

Checklist

  • Did you add new tests and confirm all tests pass? (yarn test)
  • Did you ensure any new Solidity source code files meet minimum test coverage requirements? (yarn coverage)
  • Did you update relevant docs? (docs are found in the docs folder)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • Did you run lint (yarn lint) and fix any issues?
  • Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

Testing

Mandatory section.
For each changeset, please highlight the tests you've added.

Documentation

Optional section.
Link to the doc.

@weikangsong weikangsong changed the title docs: update chain expansion guide for EP v0.6 docs: update chain expansion guide for entrypoint v0.6 May 3, 2025
README.md Outdated
4. Include the relevant logs from the `broadcast` folder in your commit.
```shell
forge script script/bytecode-deploy/107_DeploySponsorPaymasterEPv06.s.sol -vvvv --slow --broadcast --force --multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, we only have 101_DeploySponsorPaymaster.s.sol as an example on this branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed all the typos

README.md Outdated
* License: Option 5 in https://etherscan.io/contract-license-types
* Upload the JSON file
* If the contract you are verifying took constructor arguments, input the output of the below command with the `0x` prefix removed into the "Constructor Arguments ABI-encoded" section:
Use `script/bytecode-deploy/standard-json-input/SponsorPaymasterEP.json` to verify. Select the following options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, should probably use SponsorPaymaster.json

Use `script/bytecode-deploy/standard-json-input/SponsorPaymasterEP.json` to verify. Select the following options
in block explorers verify contract UI:
* Compiler Type: `Solidity(Standard-Json-Input)`
* Compiler Version: `v0.8.17`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.8.24?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sponsor paymaster on EP v0.6 uses v0.8.17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, i've been using v0.8.17 to verify source code and it works. see this https://etherscan.io/address/0x26f77C6455518CAF29A5414004C5A2Ef441228b1#code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably deployed using v0.8.17, then updated the code to v0.8.24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind approving the PR so I can merge it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but note that Compiler Version: v0.8.24 is used on line 124, do you want to change it in this PR to be consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 224 refers to the SingleOwnerMSCA contracts, which does use v0.8.24, see https://etherscan.io/address/0x11BACb0F0C9D04A28A2043b54c0C3C2CE15F0Af4#code

README.md Outdated
```shell
cast abi-encode "constructor(<arg type 1>, <arg type 2>, ...)" "arg1Val" "arg2Val"
### Deploy & Verify SingleOwnerMSCAFactory
Deploy, setup and verify SingleOwnerMSCAFactory compatible with ERC-4337 v0.6 and ERC-6900 v0.7.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: removing and ERC-6900 v0.7

README.md Outdated
Tip: if your contract's constructor arguments have complicated types, you can get this value instead by `console.log`ing the output of `abi.encode(arg1, arg2, ...)` in Solidity.
```shell
# Deploy PluginManagerEPv06
forge script script/bytecode-deploy/108_DeployPluginManagerEPv06.s.sol -vvvv --slow --broadcast --force --multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

102_DeployPluginManager.s.sol

README.md Outdated

* For account factory contracts, you may also need to manually verify the proxy contract. To do this, you will first need to create an account using the account factory, and follow the above strategy. After verifying one account, all subsequent proxies should be automatically detected.
# Deploy SingleOwnerMSCAFactoryEPv06
forge script script/bytecode-deploy/109_DeploySingleOwnerMSCAFactoryEPv06.s.sol -vvvv --slow --broadcast --force --multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

103_DeploySingleOwnerMSCAFactory.s.sol

README.md Outdated
forge script script/bytecode-deploy/108_DeployPluginManagerEPv06.s.sol -vvvv --slow --broadcast --force --multi

* For account factory contracts, you may also need to manually verify the proxy contract. To do this, you will first need to create an account using the account factory, and follow the above strategy. After verifying one account, all subsequent proxies should be automatically detected.
# Deploy SingleOwnerMSCAFactoryEPv06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy SingleOwnerMSCAFactory

README.md Outdated
forge script script/bytecode-deploy/109_DeploySingleOwnerMSCAFactoryEPv06.s.sol -vvvv --slow --broadcast --force --multi

Tip: analyze the account creation function on the factory (e.g. `createAccount` for `SingleOwnerMSCAFactory`) to deduce the constructor arguments for the proxy deployment when trying to verify it on a block explorer.
# Deploy ColdStorageAddressBookPluginEPv06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy ColdStorageAddressBookPlugin

README.md Outdated

Tip: analyze the account creation function on the factory (e.g. `createAccount` for `SingleOwnerMSCAFactory`) to deduce the constructor arguments for the proxy deployment when trying to verify it on a block explorer.
# Deploy ColdStorageAddressBookPluginEPv06
forge script script/bytecode-deploy/110_DeployColdStorageAddressBookPluginEPv06.s.sol -vvvv --slow --broadcast --force --multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

104_DeployColdStorageAddressBookPlugin.s.sol

@weikangsong weikangsong requested a review from huaweigu May 5, 2025 21:26
README.md Outdated

```shell
forge script script/bytecode-deploy/107_DeploySponsorPaymasterEPv06.s.sol -vvvv --slow --broadcast --force --multi
forge script script/bytecode-deploy/101_DeploySponsorPaymasterEPv06.s.sol -vvvv --slow --broadcast --force --multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, 101_DeploySponsorPaymaster.s.sol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@weikangsong
Copy link
Contributor Author

@huaweigu sorry for the delay, i resolved all the comments, please take a look again

@weikangsong weikangsong requested a review from huaweigu June 30, 2025 22:46
@weikangsong weikangsong merged commit a13f209 into circlefin:entry-point-v0.6 Jul 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants