-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Deploy EPv0.6 paymasters for World, Sonic, Celo mainnet and testnet #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deploy EPv0.6 paymasters for World, Sonic, Celo mainnet and testnet #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hieule-circle looks like the content didn't get committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stigter-circle constructor args added
script/bytecode-deploy/standard-json-input/SponsorPaymasterProxy.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we also verified these contracts?
// A list of chains that need to run setup work after deployment. Please adjust the list based on the chain | ||
// expansion needs. | ||
function getChainsForSetup() internal pure returns (string[4] memory) { | ||
return ["base-sepolia", "base", "op-sepolia", "op"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing testnets, op and base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I deployed the contracts for celo, sonic, and world testnet first and then celo, sonic, and world mainnet afterwards. that's why you are seeing those three chains in the getChainsForSetup() function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so these are the chains currently being deployed, we might want to consider renaming the function to better reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huaweigu yeah that makes sense, do you have any suggestions in mind? I'm thinking maybe something like getCurrentChainsForSetup(), getCurrentDeploymentChains(), etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getCurrentDeploymentChains
sounds good!
@@ -0,0 +1 @@ | |||
00000000000000000000000026f77c6455518caf29a5414004c5a2ef441228b100000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000044485cc9550000000000000000000000007e99c7725463a858c34d0fd69a09b11fd75087cc0000000000000000000000007e99c7725463a858c34d0fd69a09b11fd75087cc00000000000000000000000000000000000000000000000000000000 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit missing new line
@huaweigu Yes, the contracts have been verified. Confirmed with @stigter-circle |
Summary
This PR is to deploy EPv0.6 paymasters for World, Sonic, Celo mainnet and testnet.
Detail
Added SponsorPaymasterProxy_constructor_args and SponsorPaymasterProxy.json file which is used to verify the proxy contract after the deployment is completed successfully.
Checklist
yarn test
)yarn coverage
)docs
folder)yarn lint
) and fix any issues?yarn format:check
) and fix any issues (yarn format:write
)?Testing
Checked Block Explorer for World, Sonic, and Celo testnet and mainnet for funding, adding verifying signers, and staking. In this case, only World and Celo requires staking.
Documentation
N/A