-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Deploy EPv0.6 paymasters for World, Sonic, Celo mainnet and testnet #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
9848b03
eb7b421
52674ee
83ab606
553fdf2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hieule-circle looks like the content didn't get committed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @stigter-circle constructor args added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing testnets, op and base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I deployed the contracts for celo, sonic, and world testnet first and then celo, sonic, and world mainnet afterwards. that's why you are seeing those three chains in the getChainsForSetup() function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so these are the chains currently being deployed, we might want to consider renaming the function to better reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huaweigu yeah that makes sense, do you have any suggestions in mind? I'm thinking maybe something like getCurrentChainsForSetup(), getCurrentDeploymentChains(), etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getCurrentDeploymentChains
sounds good!