[UNTRACKED] Add whitepaper #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
approved these changes
Mar 11, 2025
zzhang-circle
pushed a commit
to zzhang-circle/evm-cctp-contracts
that referenced
this pull request
Jun 20, 2025
… CREATE2 more effectively (circlefin#60) ### Summary Follow-up to: circlefin/evm-cctp-contracts-private@8cf3673, this correct an oversight where the TokenMinterV2 via Create2 was being passed the tokenController as a constructor arg. Since this affects the bytecode, it affects the address. ### Testing The tests actually already assert that the tokenController is rotated correctly; it's done atomically in both ways, only this way ensures a consistent address. Edit: added a test to ensure that the script is deploying via CREATE2 in an expected way.
zzhang-circle
pushed a commit
to zzhang-circle/evm-cctp-contracts
that referenced
this pull request
Jun 20, 2025
… CREATE2 more effectively (circlefin#60) ### Summary Follow-up to: circlefin/evm-cctp-contracts-private@8cf3673, this correct an oversight where the TokenMinterV2 via Create2 was being passed the tokenController as a constructor arg. Since this affects the bytecode, it affects the address. ### Testing The tests actually already assert that the tokenController is rotated correctly; it's done atomically in both ways, only this way ensures a consistent address. Edit: added a test to ensure that the script is deploying via CREATE2 in an expected way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.