[BUG] Received proposals from different validators in the same round.

[SamHSmith]

I got the panic "BUG: Received proposals from different validators in the same round." at some point when running a node with a slightly wrong validator set. It would seem this should never have happened and it is hard for me to reproduce but it did happen to me as a user of the library.

[cason]

Yes, this should never happen, because before entering the driver, the Proposal's signature should be verified:

malachite/code/crates/core-consensus/src/handle/proposal.rs

Lines 75 to 77 in 10893c2

	if !verify_signed_proposal(co, state, &signed_proposal).await? {
	return Ok(());
	}

and only Proposals signed by the proposer of the Proposal's round are accepted.

[cason]

In your case, probably a bad implementation of the proposer selection algorithm allowed two proposals, from different validators, to be accepted into the driver, leading to the error.

In my opinion, we should indeed panic in this case. Maybe the message should be more clear.