Skip to content

Conversation

anilgangapersaud-circle
Copy link
Contributor

@anilgangapersaud-circle anilgangapersaud-circle commented Aug 27, 2025

This PR includes a major version bump for Nuxt and Node
Nuxt 2.15.8 -> Nuxt 3.8.0 This includes Vue 2 -> Vue 3 migration which affects all pages.
Node JS 16.13.0 -> 22.18.0

Also removed a bunch of deprecated features such as Card and Marketplace APIs

Screen.Recording.2025-08-27.at.4.39.21.PM.mov

Reviewers, please startup the app locally and ensure basic functionality works.

Comment on lines -39 to -40
## Test Card Numbers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed a bunch of Card related code now that it's deprecated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see anything I missed, please comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the addressBook pages out of the beta package

Comment on lines -5 to -6
// https://stackoverflow.com/questions/54021037/how-to-mock-window-location-href-with-jest-vuejs
delete global.window.location
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest version of Jest doesn't allow writing to the global.window at all

@anilgangapersaud-circle anilgangapersaud-circle changed the title Upgrade Nuxt Upgrade Nuxt and Node for Sample App Aug 27, 2025
@anilgangapersaud-circle anilgangapersaud-circle changed the title Upgrade Nuxt and Node for Sample App [BANK-5350] Upgrade Nuxt and Node for Sample App Aug 27, 2025
@ali-kafel ali-kafel changed the title [BANK-5350] Upgrade Nuxt and Node for Sample App [BANK-5350] Upgrade Next and Node for Sample App Aug 29, 2025
@anilgangapersaud-circle anilgangapersaud-circle changed the title [BANK-5350] Upgrade Next and Node for Sample App [BANK-5350] Upgrade Nuxt and Node for Sample App Aug 29, 2025
Copy link
Contributor

@Wongmat Wongmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks!

@timmy-circle timmy-circle merged commit 4c608c7 into circlefin:master Sep 2, 2025
3 checks passed
ali-kafel added a commit that referenced this pull request Sep 3, 2025
The start command was removed in this PR:
#405

The container is now erroring with:
```
! Corepack is about to download https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz
yarn run v1.22.22
error Command "start" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants