Skip to content

Conversation

@md-rafeek
Copy link

@md-rafeek md-rafeek commented Oct 28, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Description

As part of this bug fix, the removal of specific profile data from the wireless profile has been completed.

  1. Able to remove Feature Templates from the profile using the delete state.
  2. Able to remove SSID Details from the profile using the delete state.
  3. Able to remove AP Zone Details from the profile using the delete state.
  4. Able to remove Additional Interface Details from the profile using the delete state.
  5. Able to remove the Day N Template from the profile using the delete state.
  6. Able to remove the Sites from the profile using the delete state.
  7. Fixed the issue with Fabric Zone status comparison at the verify state.

Bug Fix:
The bug was raised for the issue where the Feature Template could not be deleted. This fix resolves that issue and also covers deletions for other fields.
When SSID details were changed under the Fabric Zone, updates were reflected, but verification failed during the playbook execution. This issue has been fixed.

Root Cause (if applicable):
The previous update API did not support updates for all fields in the wireless profile. The required fields have now been included and handled appropriately.

The comparison logic was modified — when Fabric Zone is enabled, certain field validations are not required. The necessary validation changes have been added.

Enhancement: [Brief description of the improvement/enhancement made]
Enhancement Description: [Explain what was enhanced, why, and how]
Impact Area: [Mention which part of the system/codebase is affected]

Testing Done:

  • Manual testing
  • Unit tests
  • Integration tests

Test cases covered:
Integration tests - Already covered
Unit tests - new UT added

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@madhansansel
Copy link
Collaborator

@rukapse can you please review the changes?

@madhansansel madhansansel requested a review from rukapse November 4, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants