Skip to content

Conversation

@syed-khadeerahmed
Copy link

@syed-khadeerahmed syed-khadeerahmed commented Nov 10, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Description

The update includes fixes for 2 identified bugs in the provision module.

Bug Fix:

  1. [Provision] Device not found when assigning/provsion to site.
  2. [Provision]: Provision with feature template cannot work with AttributeError: 'Provision' object has no attribute '_process_additional_identifiers'.

Root Cause (if applicable): NA

Fix Implemented:

  1. Updated the message
  2. removed _process_additional_identifiers and updated with normal workflow

Enhancement: NA
Enhancement Description: NA
Impact Area: NA

Testing Done:

  • Manual testing
  • Unit tests
  • Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@madhansansel madhansansel merged commit e75be1d into cisco-en-programmability:main Nov 10, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants