Skip to content

Conversation

@md-rafeek
Copy link

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Description

As a part of this bug fix,

  1. Special case of "ADVANCED_SSID_CONFIGURATION" validation removed
  2. When update the profile data update with existing not override.

Bug Fix:
As a part of this bug fix:
The special-case validation for "ADVANCED_SSID_CONFIGURATION" has been removed.
When updating the profile data, the update now merges with the existing data instead of overriding it.

Bug Fix:
The special validation for "ADVANCED_SSID_CONFIGURATION" has been removed so that this configuration is handled the same way as other feature templates.
For merged states, the profile information is now appended to the existing data instead of replacing it. Code changes were implemented to support this behavior.

Root Cause (if applicable):
Initially, the UI allowed adding only the ADVANCED_SSID_CONFIGURATION, but during save, all feature templates were stored. Therefore, the additional validation was unnecessary and caused inconsistencies, leading to its removal.
For merged states, profile data should have been added to the existing information, but the previous implementation overwrote the existing data. This issue has now been corrected.

Fix Implemented
Removed the condition that applied a special-case validation to ADVANCED_SSID_CONFIGURATION.

Enhancement: [Brief description of the improvement/enhancement made]
Enhancement Description: [Explain what was enhanced, why, and how]
Impact Area: [Mention which part of the system/codebase is affected]

Testing Done:

  • Manual testing
  • Unit tests
  • Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant