Merge pull request #586 from Lastique/patch-1

pabuhler · web-flow · commit f94f40216434 · 2021-12-11T14:12:57.000+01:00
Avoid initializing local char table when converting nibble to hex
diff --git a/crypto/math/datatypes.c b/crypto/math/datatypes.c
@@ -64,8 +64,8 @@ static char bit_string[MAX_PRINT_STRING_LEN + 1];
 
 uint8_t srtp_nibble_to_hex_char(uint8_t nibble)
 {
-    char buf[16] = { '0', '1', '2', '3', '4', '5', '6', '7',
-                     '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
+    static const char buf[16] = { '0', '1', '2', '3', '4', '5', '6', '7',
+                                  '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
     return buf[nibble & 0xF];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,8 @@ static char bit_string[MAX_PRINT_STRING_LEN + 1];`
`64`	`64`
`65`	`65`	`uint8_t srtp_nibble_to_hex_char(uint8_t nibble)`
`66`	`66`	`{`
`67`		`- char buf[16] = { '0', '1', '2', '3', '4', '5', '6', '7',`
`68`		`- '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };`
	`67`	`+ static const char buf[16] = { '0', '1', '2', '3', '4', '5', '6', '7',`
	`68`	`+ '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };`
`69`	`69`	`return buf[nibble & 0xF];`
`70`	`70`	`}`
`71`	`71`