Update pre-commit and fix some warnings/errors#408
Open
kurtmckee wants to merge 3 commits intocitation-file-format:mainfrom
Open
Update pre-commit and fix some warnings/errors#408kurtmckee wants to merge 3 commits intocitation-file-format:mainfrom
kurtmckee wants to merge 3 commits intocitation-file-format:mainfrom
Conversation
Found while running pre-commit in verbose mode: ```shell $ pre-commit run -av ruff ... warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`: - 'select' -> 'lint.select' - 'flake8-quotes' -> 'lint.flake8-quotes' ```
Found while running pre-commit:
```shell
$ pre-commit run -av prospector
...
src/cffconvert/cli/rawify_url.py
Line: 23
pycodestyle: E201 / whitespace after '{' (col 60)
pycodestyle: E202 / whitespace before '}' (col 66)
src/cffconvert/cli/read_from_url.py
Line: 18
pycodestyle: E201 / whitespace after '{' (col 52)
pycodestyle: E202 / whitespace before '}' (col 58)
...
```
Fixes citation-file-format#405
kurtmckee
force-pushed
the
update-pre-commit
branch
from
0c9fa70 to
90b31d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Run
pre-commit autoupdateto update all hook versionsThis resolves warnings associated with out-of-date hook versions.
Fix ruff lint warnings regarding deprecated configuration values
Fix prospector lint errors regarding whitespace in f-string substitutions
There are three errors found by
markdown-link-checkthat have not been addressed. These need to be addressed separately:Fixes #405