Skip to content

Conversation

paytonej
Copy link

  1. Merged "Metallurgical and Materials Transactions" and "Metallurgical and Materials Transactions A" styles, because they should be identical.
  2. Made "Metall Mater Trans A" style dependent on parent "Metall Mater Trans" style.
  3. Made "Metall Mater Trans B" and "Metall Mater Trans E" styles dependent on "Metall Mater Trans" style.
  4. Updated parent "Metall Mater Trans" style to include DOIs and URLs in the format used by the journal.
  5. New "Metall Mater Trans" parent style abbreviates author names, as per formatting used by the journal.
  6. Included event and publisher text in the else statement for item types, to format additional information for presentations and item types less common for materials engineering citations.

…ialization of author names; add event and publisher into else category to catch presentations and citation types that are infrequent in materials science. Fixed dependencies of Metall Mater Trans A, B, and E.
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

2 tests failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"1073-5623"=>["metallurgical-and-materials-transactions-a", "metallurgical-and-materials-transaction...3-1940"=>["metallurgical-and-materials-transactions-a", "metallurgical-and-materials-transactions"]}

(compared using ==)

Diff:
@@ -1,2 +1,4 @@
+"1073-5623" => ["metallurgical-and-materials-transactions-a", "metallurgical-and-materials-transactions"],
+"1543-1940" => ["metallurgical-and-materials-transactions-a", "metallurgical-and-materials-transactions"],

dependent/metallurgical-and-materials-transactions-a: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "2:7: FATAL: XML declaration allowed only at the start of the document"]].empty?` to be truthy, got false

Please check the test report for details.

…ed and merged with "Metall Mater Trans A." Replace "Metall Mater Trans" with "Metall Mater Trans A." Make "Metall Mater Trans B" dependent on "Metall Mater Trans A."
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

metallurgical-and-materials-transactions-a.csl (modified style)
[1,2]
[3,4]

1B. Hancké, M. Rhodes, and M. Thatcher, eds.: Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy, Oxford University Press, Oxford and New York, 2007.
2CSL search by example. http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.
3I. Mares: in Varieties of capitalism. The institutional foundations of comparative advantage, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp 184–213.
4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: Sci. Data, 2019, vol. 6, p 28. https://doi.org/10.1038/s41597-019-0031-8.
 <span style="vertical-align: super">[1,2]</span><br/>
 <span style="vertical-align: super">[3,4]</span><br/>
 <hr/>
 1B. Hancké, M. Rhodes, and M. Thatcher, eds.: <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>, Oxford University Press, Oxford and New York, 2007.<br/>
-2CSL search by example, http://editor.citationstyles.org/searchByExample/, (accessed 15 December 2012).<br/>
-3I. Mares: in <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp. 184–213.<br/>
-4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: <i>Sci. Data</i>, 2019, vol. 6, p. 28.<br/>
+2CSL search by example. http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.<br/>
+3I. Mares: in <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp 184–213.<br/>
+4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: <i>Sci. Data</i>, 2019, vol. 6, p 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
dependent/metallurgical-and-materials-transactions-b.csl (rendering failure)

Copy link

github-actions bot commented Jul 1, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-materials-research.csl (modified style)
1,2
3,4

1.B. Hancké, M. Rhodes, and M. Thatcher, editors : Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
2.Citation Style Editor (2012). http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.
3.I. Mares: in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P. A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
4.M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: A data citation roadmap for scholarly data repositories. Sci. Data 6(1), 28 (2019). https://doi.org/10.1038/s41597-019-0031-8.
 <span style="vertical-align: super">1,2</span><br/>
 <span style="vertical-align: super">3,4</span><br/>
 <hr/>
 1.B. Hancké, M. Rhodes, and M. Thatcher, editors : Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).<br/>
-2.<i>Citation Style Editor</i> (2012).<br/>
+2.<i>Citation Style Editor</i> (2012). http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.<br/>
 3.I. Mares: in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, edited by P. A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.<br/>
-4.M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: A data citation roadmap for scholarly data repositories. <i>Sci. Data</i> <b>6</b>(1), 28 (2019).<br/>
+4.M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: A data citation roadmap for scholarly data repositories. <i>Sci. Data</i> <b>6</b>(1), 28 (2019). https://doi.org/10.1038/s41597-019-0031-8.<br/>
metallurgical-and-materials-transactions-a.csl (modified style)
[1,2]
[3,4]

1B. Hancké, M. Rhodes, and M. Thatcher, eds.: Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy, Oxford University Press, Oxford and New York, 2007.
2CSL search by example. http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.
3I. Mares: in Varieties of capitalism. The institutional foundations of comparative advantage, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp 184–213.
4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: Sci. Data, 2019, vol. 6, p 28. https://doi.org/10.1038/s41597-019-0031-8.
 <span style="vertical-align: super">[1,2]</span><br/>
 <span style="vertical-align: super">[3,4]</span><br/>
 <hr/>
 1B. Hancké, M. Rhodes, and M. Thatcher, eds.: <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>, Oxford University Press, Oxford and New York, 2007.<br/>
-2CSL search by example, http://editor.citationstyles.org/searchByExample/, (accessed 15 December 2012).<br/>
-3I. Mares: in <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp. 184–213.<br/>
-4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: <i>Sci. Data</i>, 2019, vol. 6, p. 28.<br/>
+2CSL search by example. http://editor.citationstyles.org/searchByExample/ . Accessed December 15, 2012.<br/>
+3I. Mares: in <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, P.A. Hall and D. Soskice, eds., Oxford University Press, New York, 2001, pp 184–213.<br/>
+4M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark: <i>Sci. Data</i>, 2019, vol. 6, p 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
dependent/metallurgical-and-materials-transactions-b.csl (rendering failure)

Copy link

github-actions bot commented Jul 8, 2025

😟 There are some issues with your submission.

1 test failed

elsevier-with-titles-reverse-chrono: must define all macros that are called by <text/> and <key/> elements

expected `{"access"=>#<CSL::Style::Macro name="access" children=[1]>, "author"=>#<CSL::Style::Macro name="autho...cro name="publisher" children=[3]>, "year-date"=>#<CSL::Style::Macro name="year-date" children=[1]>}.has_key?("issued")` to be truthy, got false

Please check the test report for details.

@adam3smith
Copy link
Member

What the description outlines sounds good. That's not what this PR does, though. Currently it:

  • completely deleted the metal mater trans and metal mater trans e styles
  • keeps the A style and keeps the B style a dependent to that
  • add the DOI as described, but not to the metal mater trans style but to the independent journal of materials research style
  • adds an unrelated Elsevier style, which, if needed, should be in a different branch/PR

Could you please fix?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 30, 2025
@bwiernik
Copy link
Member

@paytonej Can you please make the updates requested by adam3smith?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants