-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Some fixes for #7702 (EJIL) #7704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes comma issues with newspaper articles and removes the URL for journal articles. Does not remove the URL for legal_cases, as the stylesheet mentions the possibility to include them under certain circumstances, but it still needs fixing (comma and a space are missing before "available at").
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: european-journal-of-international-law.csl (modified style); . ; .<br/>
; .<br/>
<hr/>
<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>
|
Can you please make the necessary delimiter changes for legal_case URLs? |
I didn't find the right spot directly, sorry for that (but wanted to raise awareness for the existing flaw)! I can check it in more detail and submit something over the weekend. |
Co-authored-by: Brenton M. Wiernik <bwiernik@users.noreply.github.com>
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: european-journal-of-international-law.csl (modified style); . ; .<br/>
; .<br/>
<hr/>
<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>
|
(let me fix a couple of things here before merging) |
😟 There are some issues with your submission. 1 test failedeuropean-journal-of-international-law: must validate against the CSL 1.0.1 schema
Please check the test report for details. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: european-journal-of-international-law.csl (modified style); . ; .<br/>
; .<br/>
<hr/>
-<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+<i>CSL Search by Example</i>, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>
|
Added group delimiter instead of individual prefixes/suffixes
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: european-journal-of-international-law.csl (modified style); . ; .<br/>
; .<br/>
<hr/>
-<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
-Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
+<i>CSL Search by Example</i>, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
+Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>, vols, (2007), available at https://academic.oup.com/book/5397.<br/>
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>
|
Sorry for the delay! The problem with the legal cases' URLs should be fixed with the latest commit. |
Fixes comma issues with newspaper articles and removes the URL for journal articles.
Does not remove the URL for legal_cases, as the stylesheet mentions the possibility to include them under certain circumstances, but it still needs fixing (comma and a space are missing before "available at").