Skip to content

Conversation

errotu
Copy link
Contributor

@errotu errotu commented Aug 13, 2025

Fixes comma issues with newspaper articles and removes the URL for journal articles.

Does not remove the URL for legal_cases, as the stylesheet mentions the possibility to include them under certain circumstances, but it still needs fixing (comma and a space are missing before "available at").

Fixes comma issues with newspaper articles and removes the URL for journal articles.

Does not remove the URL for legal_cases, as the stylesheet mentions the possibility to include them under certain circumstances, but it still needs fixing (comma and a space are missing before "available at").
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

european-journal-of-international-law.csl (modified style)
; .
; .

CSL Search by Example, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.
Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 Scientific Data (2019) 28.
Hancké B., Rhodes M. and Thatcher M. (eds.), Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economyvols (2007)available at https://academic.oup.com/book/5397.
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), Varieties of Capitalism: The Institutional Foundations of Comparative Advantage (2001) 184.
 ; .<br/>
 ; .<br/>
 <hr/>
 <span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
 Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
 Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>

@bwiernik
Copy link
Member

bwiernik commented Aug 13, 2025

Can you please make the necessary delimiter changes for legal_case URLs?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 13, 2025
@errotu
Copy link
Contributor Author

errotu commented Aug 13, 2025

I didn't find the right spot directly, sorry for that (but wanted to raise awareness for the existing flaw)! I can check it in more detail and submit something over the weekend.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 13, 2025
Co-authored-by: Brenton M. Wiernik <bwiernik@users.noreply.github.com>
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

european-journal-of-international-law.csl (modified style)
; .
; .

CSL Search by Example, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.
Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 Scientific Data (2019) 28.
Hancké B., Rhodes M. and Thatcher M. (eds.), Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economyvols (2007)available at https://academic.oup.com/book/5397.
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), Varieties of Capitalism: The Institutional Foundations of Comparative Advantage (2001) 184.
 ; .<br/>
 ; .<br/>
 <hr/>
 <span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
 Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
 Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>

@adam3smith
Copy link
Member

(let me fix a couple of things here before merging)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 26, 2025
Copy link

😟 There are some issues with your submission.

1 test failed

european-journal-of-international-law: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n185:71: FATAL: attributes construct error\n185:71: FATAL: Couldn't find end of Start Tag text line 185"]].empty?` to be truthy, got false

Please check the test report for details.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

european-journal-of-international-law.csl (modified style)
; .
; .

CSL Search by Example, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.
Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 Scientific Data (2019) 28.
Hancké B., Rhodes M. and Thatcher M. (eds.), Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economyvols (2007)available at https://academic.oup.com/book/5397.
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), Varieties of Capitalism: The Institutional Foundations of Comparative Advantage (2001) 184.
 ; .<br/>
 ; .<br/>
 <hr/>
-<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
+<i>CSL Search by Example</i>, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
 Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
 Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>

adam3smith and others added 2 commits August 30, 2025 04:00
Added group delimiter instead of individual prefixes/suffixes
Copy link

github-actions bot commented Sep 4, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

european-journal-of-international-law.csl (modified style)
; .
; .

CSL Search by Example, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.
Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 Scientific Data (2019) 28.
Hancké B., Rhodes M. and Thatcher M. (eds.), Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy, vols, (2007), available at https://academic.oup.com/book/5397.
Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), Varieties of Capitalism: The Institutional Foundations of Comparative Advantage (2001) 184.
 ; .<br/>
 ; .<br/>
 <hr/>
-<span style="vertical-align: baseline"><i>CSL Search by Example</i></span>, Citation Style Editor, <span style="vertical-align: baseline">2012</span>, available at http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28, available at https://www.nature.com/articles/s41597-019-0031-8.<br/>
-Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>vols (2007)available at https://academic.oup.com/book/5397.<br/>
+<i>CSL Search by Example</i>, Citation Style Editor, 2012, available at http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner et al., ‘A Data Citation Roadmap for Scholarly Data Repositories’, 6 <i>Scientific Data</i> (2019) 28.<br/>
+Hancké B., Rhodes M. and Thatcher M. (eds.), <i>Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy</i>, vols, (2007), available at https://academic.oup.com/book/5397.<br/>
 Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in P. A. Hall and D. Soskice (eds.), <i>Varieties of Capitalism: The Institutional Foundations of Comparative Advantage</i> (2001) 184.<br/>

@errotu
Copy link
Contributor Author

errotu commented Sep 4, 2025

Sorry for the delay! The problem with the legal cases' URLs should be fixed with the latest commit.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants