Feat/params dialog starter scenario #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
approved these changes
Aug 25, 2025
simulator-ui/src/main/webapp/app/scenario/list/scenario.component.spec.ts
Show resolved
Hide resolved
simulator-ui/src/main/webapp/app/scenario/list/scenario.component.spec.ts
Outdated
Show resolved
Hide resolved
valisol
force-pushed
the
feat/params-dialog-starter-scenario
branch
4 times, most recently
from
bef39e2 to
008ba5a
Compare
if starter scenario contains predefined parameters an ui pops up to define the value before launching. also fixes regression issues when displaying scenario parameters. Co-authored-by: Timon Borter <timon.borter@gmx.ch>
bbortt
force-pushed
the
feat/params-dialog-starter-scenario
branch
from
008ba5a to
c8c5212
Compare
|
@valisol I've squashed the commits and fixed the /lgtm |
bbortt
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If starter scenario contains predefined parameters an ui pops up to define the value before launching.