From 667b739a1cf471c87c228abe8844bd74fed8e339 Mon Sep 17 00:00:00 2001 From: Mehmet Yilmaz Date: Wed, 17 Dec 2025 13:49:32 +0000 Subject: [PATCH] Refactor subquery syntax in tests for clarity and consistency --- .../regress/expected/subquery_in_where.out | 22 +++++-------------- src/test/regress/sql/subquery_in_where.sql | 18 ++++----------- 2 files changed, 10 insertions(+), 30 deletions(-) diff --git a/src/test/regress/expected/subquery_in_where.out b/src/test/regress/expected/subquery_in_where.out index e614d8cba49..4d00936ef5d 100644 --- a/src/test/regress/expected/subquery_in_where.out +++ b/src/test/regress/expected/subquery_in_where.out @@ -735,23 +735,13 @@ WHERE -- make the clause recurring CREATE TABLE local_table(id int, value_1 int); INSERT INTO local_table VALUES(1,1), (2,2); -SELECT - * -FROM - (SELECT - * - FROM - local_table) as sub_table -WHERE - id -IN - (SELECT - user_id - FROM - users_table); +SELECT s.* +FROM (SELECT * FROM local_table) AS s +WHERE s.id IN (SELECT u.user_id FROM users_table u) +ORDER BY s.id; DEBUG: generating subplan XXX_1 for subquery SELECT id, value_1 FROM subquery_in_where.local_table -DEBUG: generating subplan XXX_2 for subquery SELECT user_id FROM public.users_table -DEBUG: Plan XXX query after replacing subqueries and CTEs: SELECT id, value_1 FROM (SELECT intermediate_result.id, intermediate_result.value_1 FROM read_intermediate_result('XXX_1'::text, 'binary'::citus_copy_format) intermediate_result(id integer, value_1 integer)) sub_table WHERE (id OPERATOR(pg_catalog.=) ANY (SELECT intermediate_result.user_id FROM read_intermediate_result('XXX_2'::text, 'binary'::citus_copy_format) intermediate_result(user_id integer))) +DEBUG: generating subplan XXX_2 for subquery SELECT user_id FROM public.users_table u +DEBUG: Plan XXX query after replacing subqueries and CTEs: SELECT id, value_1 FROM (SELECT intermediate_result.id, intermediate_result.value_1 FROM read_intermediate_result('XXX_1'::text, 'binary'::citus_copy_format) intermediate_result(id integer, value_1 integer)) s WHERE (id OPERATOR(pg_catalog.=) ANY (SELECT intermediate_result.user_id FROM read_intermediate_result('XXX_2'::text, 'binary'::citus_copy_format) intermediate_result(user_id integer))) ORDER BY id id | value_1 --------------------------------------------------------------------- 1 | 1 diff --git a/src/test/regress/sql/subquery_in_where.sql b/src/test/regress/sql/subquery_in_where.sql index 60a69a3bb03..ffdee1282ec 100644 --- a/src/test/regress/sql/subquery_in_where.sql +++ b/src/test/regress/sql/subquery_in_where.sql @@ -542,20 +542,10 @@ WHERE CREATE TABLE local_table(id int, value_1 int); INSERT INTO local_table VALUES(1,1), (2,2); -SELECT - * -FROM - (SELECT - * - FROM - local_table) as sub_table -WHERE - id -IN - (SELECT - user_id - FROM - users_table); +SELECT s.* +FROM (SELECT * FROM local_table) AS s +WHERE s.id IN (SELECT u.user_id FROM users_table u) +ORDER BY s.id; -- Use local table in WHERE clause SELECT