MembershipType - Show titles instead of name on admin page/form

Author: colemanw

CRM/Member/Form/MembershipType.php

@@ -30,10 +30,15 @@ class CRM_Member_Form_MembershipType extends CRM_Member_Form_MembershipConfig {
    */
   protected function setEntityFields() {
     $this->entityFields = [
-      'name' => [
+      'title' => [
         'required' => 'TRUE',
-        'name' => 'name',
-        'description' => ts("e.g. 'Student', 'Senior', 'Honor Society'..."),
+        'name' => 'title',
+        'description' => ts("Internal name, e.g. 'Student', 'Senior', 'Honor Society'..."),
+      ],
+      'frontend_title' => [
+        'required' => 'TRUE',
+        'name' => 'frontend_title',
+        'description' => ts('Name as shown on public pages.'),
       ],
       'description' => [
         'name' => 'description',
@@ -225,11 +230,8 @@ public function buildQuickForm() {
     // Fields in this array have been tested & in the tpl have been switched over to metadata.
     // Note this kinda 'works from the top' - ie. once we hit a field that needs some thought we need
     // to stop & make that one work.
-    $this->assign('tpl_standardised_fields', ['name', 'description', 'member_of_contact_id', 'minimum_fee']);
+    $this->assign('tpl_standardised_fields', ['title', 'frontend_title', 'description', 'member_of_contact_id', 'minimum_fee']);
 
-    $this->addRule('name', ts('A membership type with this name already exists. Please select another name.'),
-      'objectExists', ['CRM_Member_DAO_MembershipType', $this->_id]
-    );
     $this->addRule('minimum_fee', ts('Please enter a monetary value for the Minimum Fee.'), 'money');
 
     $props = ['api' => ['params' => ['contact_type' => 'Organization']]];
@@ -292,10 +294,6 @@ public function buildQuickForm() {
   public static function formRule($params) {
     $errors = [];
 
-    if (!$params['name']) {
-      $errors['name'] = ts('Please enter a membership type name.');
-    }
-
     if (($params['minimum_fee'] > 0) && !$params['financial_type_id']) {
       $errors['financial_type_id'] = ts('Please enter the financial Type.');
     }

CRM/Member/Page/MembershipType.php

@@ -101,7 +101,8 @@ public function browse(): void {
       ->setSelect([
         'id',
         'domain_id',
-        'name',
+        'title',
+        'frontend_title',
         'fixed_period_start_day',
         'fixed_period_rollover_day',
         'max_related',

templates/CRM/Member/Page/MembershipType.tpl

@@ -23,6 +23,7 @@
       <thead>
       <tr>
         <th>{ts}Membership{/ts}</th>
+        <th>{ts}Frontend Title{/ts}</th>
         <th>{ts}Period{/ts}</th>
         <th>{ts}Fixed Start{/ts}</th>
         <th>{ts}Minimum Fee{/ts}</th>
@@ -38,7 +39,8 @@
       </thead>
       {foreach from=$rows item=row}
         <tr id="membership_type-{$row.id}" class="crm-entity {cycle values='odd-row,even-row'} crm-membership-type {if NOT $row.is_active} disabled{/if}">
-          <td class="crmf-name crm-editable" data-field="name">{$row.name}</td>
+          <td class="crm-editable" data-field="title">{$row.title}</td>
+          <td class="crm-editable" data-field="frontend_title">{$row.frontend_title}</td>
           <td class="crmf-period_type crm-editable" data-type="select">{$row.period_type}</td>
           <td class="crmf-fixed_period_start_day">{$row.fixed_period_start_day}</td>
           <td class="crmf-minimum_fee" align="right">{$row.minimum_fee|crmMoney}</td>
@@ -64,7 +66,7 @@
 {else}
   {if $action ne 1}
   <div class="messages status no-popup">
-    {icon icon="fa-info-circle"}{/icon} 
+    {icon icon="fa-info-circle"}{/icon}
     {capture assign=crmURL}{crmURL p='civicrm/admin/member/membershipType/add' q="action=add&reset=1"}{/capture}{ts 1=$crmURL}There are no membership types entered. You can <a href='%1'>add one</a>.{/ts}
   </div>
   {/if}

tests/phpunit/CRM/Member/Page/MembershipTypeTest.php

@@ -30,7 +30,8 @@ public function testMembershipTypePage(): void {
       $id => [
         'id' => '1',
         'domain_id' => '1',
-        'name' => 'General',
+        'title' => 'General',
+        'frontend_title' => 'General',
         'member_of_contact_id' => '3',
         'financial_type_id' => '2',
         'minimum_fee' => 0.0,