Remove legacy MembershipPayment check from test

mattwire · mattwire · commit 9b604c95aa76 · 2025-12-05T17:11:55.000Z
diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -3581,13 +3581,8 @@ protected function validateAllContributions(): void {
           $participants[$lineItem['entity_id']] = $lineItem['entity_id'];
         }
       }
-      $membershipPayments = $this->callAPISuccess('MembershipPayment', 'get', ['contribution_id' => $contribution['id'], 'return' => 'membership_id', 'version' => 3])['values'];
       $participantPayments = $this->callAPISuccess('ParticipantPayment', 'get', ['contribution_id' => $contribution['id'], 'return' => 'participant_id', 'version' => 3])['values'];
-      $this->assertCount(count($memberships), $membershipPayments);
       $this->assertCount(count($participants), $participantPayments);
-      foreach ($membershipPayments as $payment) {
-        $this->assertContains($payment['membership_id'], $memberships);
-      }
       foreach ($participantPayments as $payment) {
         $this->assertContains($payment['participant_id'], $participants);
       }

Original file line number	Diff line number	Diff line change
`@@ -3581,13 +3581,8 @@ protected function validateAllContributions(): void {`
`3581`	`3581`	`$participants[$lineItem['entity_id']] = $lineItem['entity_id'];`
`3582`	`3582`	`}`
`3583`	`3583`	`}`
`3584`		`- $membershipPayments = $this->callAPISuccess('MembershipPayment', 'get', ['contribution_id' => $contribution['id'], 'return' => 'membership_id', 'version' => 3])['values'];`
`3585`	`3584`	`$participantPayments = $this->callAPISuccess('ParticipantPayment', 'get', ['contribution_id' => $contribution['id'], 'return' => 'participant_id', 'version' => 3])['values'];`
`3586`		`- $this->assertCount(count($memberships), $membershipPayments);`
`3587`	`3585`	`$this->assertCount(count($participants), $participantPayments);`
`3588`		`- foreach ($membershipPayments as $payment) {`
`3589`		`- $this->assertContains($payment['membership_id'], $memberships);`
`3590`		`- }`
`3591`	`3586`	`foreach ($participantPayments as $payment) {`
`3592`	`3587`	`$this->assertContains($payment['participant_id'], $participants);`
`3593`	`3588`	`}`